Closed eliserichards closed 2 years ago
When we used the ConcatAdapter
in the tabs tray it came with some side-effects that are worth noting:
ItemDecoration
can be annoying if you need to have different decorations for each adapter's ViewHolders and now you need to combine them into one.See: https://github.com/mozilla-mobile/fenix/issues/17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Removing "won't-fix". This issue may still be valid.
See: https://github.com/mozilla-mobile/fenix/issues/17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Related to #15577, #16215
Refactor the recycler views in history, bookmarks, downloads (and maybe logins too?) to use https://developer.android.com/reference/androidx/recyclerview/widget/ConcatAdapter (or another option).
Current implementation does some weird stuff in order to have the Delete button in the scroll view: https://github.com/mozilla-mobile/fenix/blob/655a5cbf5439c162b6c221031dc7f2606eb0bc9f/app/src/main/java/org/mozilla/fenix/library/history/HistoryAdapter.kt#L47
┆Issue is synchronized with this Jira Task