search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

PWAs with no name default to "Web page" #17192

Closed jurica1304 closed 1 year ago

jurica1304 commented 3 years ago

Steps to reproduce

  1. go to https://ocjene.skole.hr/login
  2. open menu in toolbar
  3. tap 'Install'

Expected behavior

It should ask you to add shortcut to launcher home page with the website title 'e-Dnevnik za učenike i roditelje'.

Actual behavior

It wants to add shortcut with the title 'Web stranica' meaning 'Web page'. App language is Croatian. Normal behavior in Google Chrome.

Device information

┆Issue is synchronized with this Jira Task

mcarare commented 3 years ago

The problem is within the website itself, the manifest does not provide a name or a shortName.

But maybe we should fallback to the session title and only after that to the hardcoded title.

anotherus3r commented 3 years ago

An option to change the name before adding it to the homescreen, like in Chrome, would also be great. Is there an open issue/feature request for this already?

mcarare commented 3 years ago

@anotherus3r I think you are referring to a shortcut, AFAIK a PWA name should not be changed if it exists in the manifest.

anotherus3r commented 3 years ago

@mcarare Opening, for example, Twitter in Chrome and choosing the option to add it to the homescreen (I presume that's the equivalent to Fenix's "Install" option) still let's me change the name. Or did I make a mistake somewhere?

mcarare commented 3 years ago

@anotherus3r No, you are right. I am just saying that if Chrome lets you change a PWA's name, it does not mean that it should. IMO the name should respect PWA's name from manifest if that name is set.

anotherus3r commented 3 years ago

@mcarare Oh, understood.😉 Though this would be useful in situations like this one.

cpeterso commented 1 year ago

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807422

Change performed by the Move to Bugzilla add-on.