search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

CustomTabsCallback Navigation Event Support in Fenix #17241

Closed kevvurs closed 1 year ago

kevvurs commented 3 years ago

Will the Mozilla Mobile team consider supporting CustomTabsCallback, e.g. for onNavigationEvent(int, Bundle)? I believe this is defined by the spec with codes for each event. Chrome and Chromium-based browsers support this feature. However, using this appears to exclude Firefox users from receiving certain helpful features. For example, using navigation events is helpful for solving edge cases in authentication through CustomTabs where the user may drop-off for too long and resume a tab with an expired session, causing login to fail. Will there be support for navigation events in Firefox CustomTabs in the future?

┆Issue is synchronized with this Jira Task

RFonzi commented 2 years ago

Lack of support here currently breaks Spotify's Auth SDK for Firefox users: https://github.com/spotify/android-auth

Their implementation depends on the TAB_HIDDEN navigation event to know the user has cancelled their authentication flow. That event never fires off when using Firefox, which results in a janky transparent overlay for apps attempting to use their Auth SDK. This flow works as intended when using Chrome.

boek commented 1 year ago

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1812842

Change performed by the Move to Bugzilla add-on.