mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.28k forks source link

When 'Share image' to Evernote/Whatsapp causes an error message #18547

Closed ErissonB closed 3 years ago

ErissonB commented 3 years ago

Steps to reproduce

When trying to share the image from contextual menu "Share Image" to Whatsapp or Evernote, you receive an error message or the application does not open.

Expected behavior

Being able to share the image for the aforementioned apps as it happens in the Brave app. (https://i.imgur.com/jnDz8Dq.png)

Actual behavior

After selecting the apps in the sharing menu, Whatsapp returns an error message and Evernote doesn't even open. (https://i.imgur.com/yGsbtlx.png)

About the tests

I tested it on Firefox Beta for Android and Firefox Nightly, with two file formats (.png and .jpg, links to the images used below).

https://media.discordapp.net/attachments/750870690634268756/822200600812716082/test.png https://cdn.discordapp.com/attachments/750870690634268756/822200618633527346/test.jpg

Device information

If more information is needed to reproduce the error, just ask.

┆Issue is synchronized with this Jira Task

LaurentiuApahideanSV commented 3 years ago

@ErissonB I tried to reproduce your issue but was unable to. Could you please specify the manufacturer and model of the device you are using?

Devices used:

ErissonB commented 3 years ago

@LaurentiuApahideanSV I used a Motorola One Hyper with Android 10 (Build number QPFS30.103-43-14).

Apps version

hollowstrawberry commented 3 years ago

This also happens to me when sharing images from Google search. Doesn't happen on other browsers or with apps other than WhatsApp

Motorola G8 Power on Android 11, latest WhatsApp version

Mugurell commented 3 years ago

I tried the two links posted in the first comment and for me sharing to WhatsApp and Evernote works as expected.

https://user-images.githubusercontent.com/11428869/112591748-81e63980-8e0d-11eb-96d9-56172a079aca.mp4

Saw an issue with Telegram not recognizing webp files - https://github.com/mozilla-mobile/fenix/issues/18547 and it's possible other apps don't recognize different formats. So it's very important to have the link of the image for which the sharing fails tp be able to reproduce this issue and know which formats aren't recognized by which apps.

hollowstrawberry commented 3 years ago

I tried the two links posted in the first comment and for me sharing to WhatsApp and Evernote works as expected. Saw an issue with Telegram not recognizing webp files - #18547 and it's possible other apps don't recognize different formats. So it's very important to have the link of the image for which the sharing fails tp be able to reproduce this issue and know which formats aren't recognized by which apps.

I believe the sharing process by Firefox produces some sort of edge case in the picture's metadata that some apps can still recognize but not others. Again this happens with jpg and png as well, and only in the Firefox browser.

You can see this happening with this image in the video below https://upload.wikimedia.org/wikipedia/commons/thumb/b/bf/Bucephala-albeola-010.jpg/1280px-Bucephala-albeola-010.jpg

https://user-images.githubusercontent.com/33796679/112631687-f329ea80-8e15-11eb-9a68-393d887842f4.mp4

Mugurell commented 3 years ago

Thank you for the video! Tried the same scenario and I can see know how sharing fails. Seems like going through WhatsApp to pick a contact to share to works (and this is the only option allowed by Chrome) But not sharing to a quick contact with

{act=android.intent.action.SEND typ=image/jpeg flg=0xb080001 cmp=com.whatsapp/.ContactPicker (has extras)}

https://user-images.githubusercontent.com/11428869/112637883-4cf6d880-8e47-11eb-8a2e-a2385a970d56.mp4

  I'm seeing this as more of a problem in the WhatsApp application but it's something to consider for whether to change to a custom share sheet to not offer that quick share option.

hollowstrawberry commented 3 years ago

Oh interesting, I didn't consider it could be the quick share option itself.

creatubers commented 3 years ago

I just installed Firefox 88 on my OnePlus 7T (Android 11) and the bug still persists.

hollowstrawberry commented 3 years ago

Yeah this is clearly a problem with Firefox not formatting the file properly for quick share, as every other app works fine with quick share