search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] address bar is partly hidden after using fullscreen mode (Device with physical buttons issue) #1998

Closed cadeyrn closed 4 years ago

cadeyrn commented 5 years ago

Steps to reproduce

  1. open https://davidwalsh.name/demo/fullscreen.php
  2. press "Launch Fullscreen" button
  3. press "Hide Fullscreen" button

Expected behavior

The browser toolbar is visible.

Actual behavior

Only the half of the browser toolbar is visible and you can't make it fully visible.

Device information

┆Issue is synchronized with this Jira Task

ekager commented 5 years ago

This will also be closed by https://github.com/mozilla-mobile/fenix/pull/1999

cadeyrn commented 5 years ago

@ekager It's not fixed by #1999.

ekager commented 5 years ago

There hasn't been a new build today yet with #1999 included, did you build master locally?

cadeyrn commented 5 years ago

Yes, I tested with a new build from master (after f897c2e295cd1b97d4024c7a9cb45dceb7a2fa89 so #1999 is included).

ekager commented 5 years ago

Have you tested this again? I am not able to reproduce on my device on master.

cadeyrn commented 5 years ago

Yes. I compiled a new build from master (after e6c34f7045f36c091848c0ecaffbb09d5c95d35e) and it's still an issue.

lobontiumira commented 5 years ago

Hi,

I can reproduce this issue on HTC 10 (Android 8.0), on the latest build 1.0.1920 (#11350639). I followed the STR from Comment 0:

  1. Open https://davidwalsh.name/demo/fullscreen.php
  2. Tap on "Launch Fullscreen" from the page loaded at Step 1.
  3. Tap on "Hide Fullscreen" from the page loaded at Step 1.
  4. Observe the address bar.

Thanks,

Notes: Not reproducible on Google Pixel (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1).

ekager commented 5 years ago

See also #2101 where an HTC device is having issues with the window flags we are settings. Possibly related.

sblatz commented 5 years ago

I have a feeling this may have been fixed by disabling the dynamic toolbar. I don't have an HTC device on hand, though. @softvision-miralobontiu are you able to reproduce still?

cadeyrn commented 5 years ago

No, disabling the dynamic toolbar did not fix this issue.

lobontiumira commented 5 years ago

Still reproducing with the latest build 1.0.1922 (#11501805), on HTC 10 (Android 8).

sblatz commented 5 years ago

I time-boxed an investigation for this and cannot seem to find any reports of HTC not respecting certain window flags. My thought is redrawing the window when exiting fullscreen could help if it's stuck in this broken state, but that's really just a band-aid.

I also don't have an HTC device to be able to test any solutions I have. I'm going to leave this ticket open for an engineer who has an HTC device to pick up.

sv-ohorvath commented 5 years ago

@sblatz This is not an HTC device issue, it's happening on devices with physical buttons: e.g. HTC 10, Samsung Galaxy Tab 3, Xiaomi Mi 4i.

ekager commented 5 years ago

Hi @sv-ohorvath ! Just added a change to test something that may fix this issue but really not positive. Could someone test with one of these physical button devices? Thanks!

cadeyrn commented 5 years ago

@ekager It's fixed by your change (HTC U11).

ekager commented 5 years ago

That's great! Because I wasn't sure what else to try ;) Will wait for QA confirmation as well, but glad it fixed your device @cadeyrn thanks for checking!

lobontiumira commented 5 years ago

Verified as fixed with the latest build 1.0.1923 (#11590616), with Samsung Galaxy Tab A 6 (Android 5.1.1), and THTC 10 (Android 8).