search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] It's not possible to distinguish between bookmarks and history suggestions on the address bar. #2037

Closed Lululalu closed 4 years ago

Lululalu commented 5 years ago

Steps to reproduce

Browser a website Save some pages as bookmarks Type the title of some of the page's you browsed previously on the address bar

Expected behavior

You can tell where the suggestions are coming from through icons (bookmarks, history, etc)

Actual behavior

On the address bar Fenix has a magnifying glass icon for search suggestions, a chain icon for link on the clipboard, but it has no icons for history and bookmarks, instead showing empty favicons box with letters inside, which makes it impossible to tell these two apart.

Device information

┆Issue is synchronized with this Jira Task

ekager commented 5 years ago

I do think this would help clarify awesomebar results for people. Could we just add the star favorite icon instead of the site favicon here?

topotropic commented 5 years ago

@Verdi what's your take on this?

Verdi commented 5 years ago

I don't know the history here or whether there was a conscious decision not to denote bookmark URLs in Fenix (maybe @shorlander knows?).

We don't have much data on this topic. A desktop eyetracking study showed that chunking (grouping bookmarks) and favicons helped in bookmark recognition but it wasn't very significant. As far as I know, showing a bookmark star is something we’ve just always done. I suspect the favicon, title and url are much more important than a bookmark star. I doubt it hurts though. Also, I don't believe we show an icon for history - just bookmarks, open tabs and search suggestions. Looking at Fennec, Fenix and iOS, my guess is the fake favicons (colored square with a letter) are not particularly helpful. On desktop we use a globe with meridian lines. It may be that it's neutral appearance helps actual favicons stand out more.

lime124 commented 5 years ago

this is going to take some more investigation and design work to ensure there is a consistent cross-product experience of how results are being displayed. i'm going to open a new issue to cover that and link this to it. removing ux label

ekager commented 5 years ago

I think it would also be more helpful to do #482 (deduping/merging equal results) In AC see: https://github.com/mozilla-mobile/android-components/issues/1368 and https://github.com/mozilla-mobile/android-components/issues/1367

pocmo commented 5 years ago

Are you sure about the merging? Those are two separate actions (Switching to an open tab vs. visiting a page). Comparing with desktop I also get both options - they just visually look different (Visit vs. Switch).

ekager commented 5 years ago

@pocmo History and Bookmarks should both be opening a new tab with the URL, right? It's the current sessions that have a different action? Like mentioned in the AC bugs, maybe we can group by action and dedupe/merge there?

ekager commented 5 years ago

Like mentioned here https://github.com/mozilla-mobile/android-components/issues/1368

kbrosnan commented 4 years ago

Duplicate of #12622