search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.48k stars 1.28k forks source link

[Bug] "Entering full screen mode" snackbar covers media players' controls. #2253

Closed Lululalu closed 4 years ago

Lululalu commented 5 years ago

Steps to reproduce

Go to a website that contains videos Play a video Go full screen

Expected behavior

Video controls are not covered

Actual behavior

Controls are covered ScreenshotUNITO-UNDERSCORE!20190503-001622!UNITO-UNDERSCORE!Gallery!

Device information

┆Issue is synchronized with this Jira Task

cadeyrn commented 5 years ago

I don't see a bug in the described behaviour. The snackbar is always on the same position and disappers after a few seconds.

ekager commented 5 years ago

Is this about the time it takes for the snackbar to disappear? It's currently Snackbar.LENGTH_LONG we could easily change it so Snackbar.LENGTH_SHORT

ekager commented 5 years ago

Could we get UX feedback on the time length of this snackbar (and this snackbar in general I suppose)?

lime124 commented 5 years ago

i believe @topotropic has some rules for snackbar behaviour.

topotropic commented 5 years ago

@ekager what's the rational behind having a Snackbar here? I'm just wondering if we need it at all – if we want to keep it, we'd have to render it above the navigational controls.

lime124 commented 5 years ago

From UX meeting: Make the duration shorter and offset it so it doesn't cover the controls.

ekager commented 5 years ago

There is not a simple way to place the snackbar above media controls since different sites may place these controls in different places. For now I've discussed a short term solution with @topotropic to just shorten the snackbar length, but we should revisit this later.

kbrosnan commented 5 years ago

For the fullscreen case we should be able to position the notification above our default controls which we fail to do.

We should verify this works in the portrait case as well.

ekager commented 5 years ago

Alright I've updated this for the snackbar to appear over the normal toolbar location. Do we think we can close this bug?

lobontiumira commented 5 years ago

Verified as fixed on the latest build 1.0.1924 (#11630619), with Samsung Galaxy A 6 (Android 5.1.1), and Google Pixel 3 (Android 9). The "Entering full screen mode" is displayed shortly and doesn't cover the control buttons.