search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

Split full name in the Address Editor into First, Middle, and Last name #24971

Closed gabrielluong closed 2 years ago

gabrielluong commented 2 years ago

The AS Address data type currently expects first, middle, and last name instead of a single full name field. Rather than parsing the full name into its first, middle and last name, I have requested UX to provide designs that would align with desktop.

Screen Shot 2022-04-26 at 4 07 40 PM

This is pending designs.

┆Issue is synchronized with this Jira Task

mcarare commented 2 years ago

@gabrielluong Does the A-S entity map exactly to the one in AC? In A-S I see this address

I do not see a city field, for example, and different naming for name parts ("first name" versus "given name") might be confusing when coding.

gabrielluong commented 2 years ago

@gabrielluong Does the A-S entity map exactly to the one in AC? In A-S I see this address

I do not see a city field, for example, and different naming for name parts ("first name" versus "given name") might be confusing when coding.

Yes the Address in AC maps directly to the AS autofill.udl. The city might be addressLevel2 based on the description and desktop https://searchfox.org/mozilla-central/source/toolkit/components/formautofill/FormAutofillUtils.jsm#1083. Regarding the naming vs AS, I think this is more of a UX consideration and we should just follow what makes sense from a UX content strategy.

@Alexandru2909 I am not expecting this to be ready to implement since we don't have designs for this.

delia-pop commented 2 years ago

Verified as fixed on Nightly 102 from 05/25.