Bug #1815564 - Modify password field text to using Roboto monospace and Added Asterisk over Bullet on password fields.

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android

https://github.com/mozilla-mobile/firefox-android

Mozilla Public License 2.0

6.47k stars 1.27k forks source link

Bug #1815564 - Modify password field text to using Roboto monospace and Added Asterisk over Bullet on password fields. #28662

Closed gitstart closed 1 year ago

gitstart commented 1 year ago

Modify password field text to using Roboto monospace && add password reveal toggle on Add Login Screen. Screens need refactor:

AddLoginFragment
LoginDetailsFragment
EditLoginFragment

Enhancement Task

Added Asterisk over Bullet

Issue Screenshots

Issue Video

Fix Screenshots

fnxoss-40-fix.webm

Pull Request checklist

[x] Tests: This PR includes thorough tests or an explanation of why it does not
[x] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
[x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

[x] QA Needed

GitHub Automation Fixes https://github.com/mozilla-mobile/fenix/issues/28609 Fixes #28609

firefoxci-taskcluster[bot] commented 1 year ago

No Taskcluster jobs started for this pull request

```js The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the default branch) does not allow starting tasks for this pull request. ```

gabrielluong commented 1 year ago

Hey @gitstart, thank you for the contribution! We have migrated the original issue over to Bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1815564. Could you please update your commit message and PR title to reference the new Bugzilla issue using the following format: "Bug xxxxxx - "

Thanks!

gitstart commented 1 year ago

Hey @gitstart, thank you for the contribution! We have migrated the original issue over to Bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1815564. Could you please update your commit message and PR title to reference the new Bugzilla issue using the following format: "Bug xxxxxx - "

Thanks!

Thank you @gabrielluong for reviewing PR. As per the contribution document, it's still shows For XXXX.

mergify[bot] commented 1 year ago

This pull request has conflicts when rebasing. Could you fix it @gitstart? 🙏

gabrielluong commented 1 year ago

Hey @gitstart, Thank you so much for your contribution. It’s much appreciated. Unfortunately, we are in the process of moving this repository to firefox-android early next week, and won’t be able to review or land any PRs until after the migration. Please feel free to reopen a new PR against the new repo once migration is complete. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see https://github.com/mozilla-mobile/fenix/issues/26855.