Bug 1814224 - Remove select tab use case wrapper

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android

https://github.com/mozilla-mobile/firefox-android

Mozilla Public License 2.0

6.48k stars 1.27k forks source link

Bug 1814224 - Remove select tab use case wrapper #28738

Closed MozillaNoah closed 1 year ago

MozillaNoah commented 1 year ago

Pull Request checklist

[ ] Tests: This PR includes thorough tests or an explanation of why it does not
[ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
[ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

[x] QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

Click on Checks at the top of the PR page.
Click on the firefoxci-taskcluster group on the left to expand all tasks.
Click on the build-debug task.
Click on View task in Taskcluster in the new DETAILS section.
The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

MozillaNoah commented 1 year ago

Unrelated, but I also noticed that the handleMultiSelectClicked path does not have test coverage, so I opened:

https://bugzilla.mozilla.org/show_bug.cgi?id=1814506

gabrielluong commented 1 year ago

Just a gotcha, if the the PR title isn't formatted with the bug number when it is first opened, then it won't be automatically linked to the Bugzilla. The integration is fairly strict since it only works once when the PR is opened and changing the title won't link it either. We could suggest improvements to the bmo team, but this is the current limitation. https://bugzilla.mozilla.org/show_bug.cgi?id=1814224

MozillaNoah commented 1 year ago

Just a gotcha, if the the PR title isn't formatted with the bug number when it is first opened, then it won't be automatically linked to the Bugzilla. The integration is fairly strict since it only works once when the PR is opened and changing the title won't link it either. We could suggest improvements to the bmo team, but this is the current limitation. https://bugzilla.mozilla.org/show_bug.cgi?id=1814224

Will I need to re-make this PR then, or just manually make state changes now?

gabrielluong commented 1 year ago

Just a gotcha, if the the PR title isn't formatted with the bug number when it is first opened, then it won't be automatically linked to the Bugzilla. The integration is fairly strict since it only works once when the PR is opened and changing the title won't link it either. We could suggest improvements to the bmo team, but this is the current limitation. https://bugzilla.mozilla.org/show_bug.cgi?id=1814224

Will I need to re-make this PR then, or just manually make state changes now?

You could just go to Bugzilla and manually attach it.