Closed mavduevskiy closed 1 year ago
Hey @mavduevskiy, we have migrated the original issue over to Bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1815637. When this is ready to land, could we please update your commit message and PR title to reference the new Bugzilla issue using the following format: "Bug xxxxxx - \<short description>". Thanks!
will be done in monorepo
Getting back to the RTL PR that caused regression and was reverted.
We use
android:textAlignment="viewStart"
already in many text views in the app, but not in everytextView
, which makes the UI inconsistent for RTL locales. Setting supporting RTL text alignment in styles does look like the right way of doing it.The problem that the first PR caused:
android:textAlignment
overrides horizontal gravity. Views that had manually setgravity
(center, center_horizontal) got broken because of that.I tried to change the layouts as little as possible, adding the
cener
textAlignment
for the textViews that want the text to be in the middle while having0width
.As a follow up, I will remove manually set
android:textAlignment="viewStart"
in textViews, since the code is duplicated.Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-debug
task.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
Fixes #7861