mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

Bug 1811537 - Add secret setting allowing to overwrite the `country` and `city` parameters for Pocket sponsored stories #28745

Closed Alexandru2909 closed 1 year ago

Alexandru2909 commented 1 year ago

For 1811537 - Add secret setting allowing to overwrite the country and city parameters for Pocket sponsored stories.

https://user-images.githubusercontent.com/35462038/217459793-4f3cd12f-1e1f-4260-9868-21b94b83c372.mp4

Pull Request checklist

QA

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #28791

gabrielluong commented 1 year ago

@Alexandru2909 Please use the correct format for the Bugzilla issues in your PR title and commit message otherwise they won't be linked to Bugzilla: Bug xxxxxx -.

The Bugzilla/GitHub integration is only ran once when you open your PR. You'll need to manually link this PR to the Bugzilla issue.

Mugurell commented 1 year ago

Could we put the new settings in a separate menu maybe similar to the "HTTPs-Only Mode" one? Going by the video, as an outside user the screen becomes a bit bloated so a separate menu could help with this and also make the correlation between Site parameter / City parameter and the Pocket sponsored stories feature clearer.

mergify[bot] commented 1 year ago

This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏