⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
It seems like the previous call for the migration was not consistently working, on nightly the searchEngines list was not completely loaded when calling the migration. The method call was moved to waitForSelectedOrDefaultSearchEngine since here we know for sure that the list is loaded (Kudos to @Mugurell for helping me with this). Since unified search will require a restart, the migration does not happen immediately after activating the feature, but only when manually restarting the app.
[ ] Tests: This PR includes thorough tests or an explanation of why it does not
[X] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
[X] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.
QA
[x] QA Needed
To download an APK when reviewing a PR (after all CI tasks finished running):
Click on Checks at the top of the PR page.
Click on the firefoxci-taskcluster group on the left to expand all tasks.
Click on the build-debug task.
Click on View task in Taskcluster in the new DETAILS section.
The APK links should be on the right side of the screen, named for each CPU architecture.
It seems like the previous call for the migration was not consistently working, on nightly the searchEngines list was not completely loaded when calling the migration. The method call was moved to
waitForSelectedOrDefaultSearchEnginesince here we know for sure that the list is loaded (Kudos to @Mugurell for helping me with this). Since unified search will require a restart, the migration does not happen immediately after activating the feature, but only when manually restarting the app.Video for behavior when restarting:
https://user-images.githubusercontent.com/32488956/217195878-80818cf2-b544-4e3d-8e3b-c511524494e9.mp4
Video for behavior when activating unified search and instead of restarting the app, open the app from the widget:
https://user-images.githubusercontent.com/32488956/217196294-9f6dc251-86a2-4a57-af71-94009c723bfe.mp4
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-debugtask.View task in Taskclusterin the newDETAILSsection.GitHub Automation
Used by GitHub Actions.