mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

Bug 1808358 - Use OnboardingPage component in NotificationPermissionDialogScreen #28776

Closed rahulsainani closed 1 year ago

rahulsainani commented 1 year ago

– Using OnboardingPage added in #28630 in NotificationPermissionDialogScreen.

Next Steps

– Use OnboardingPage in Onboarding (rename to UpgradeOnboarding)

Pull Request checklist

QA

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

gabrielluong commented 1 year ago

Hey @rahulsainani, the team is in the process of moving this repository to firefox-android early next week, and won’t be able to review or land any PRs until after the migration. Please feel free to reopen a new PR against the new repo once migration is complete. You will have to clone the new repository and reapply your changes. Sorry for the inconvenience.

rahulsainani commented 1 year ago

Thanks for the heads up @gabrielluong ! Makes sense, will open this on the monorepo 👍