mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.48k stars 1.27k forks source link

Bug 1811795 - Surface granular media permissions. #28783

Closed mcarare closed 1 year ago

mcarare commented 1 year ago

This is a break-out from https://github.com/mozilla-mobile/fenix/pull/27883 that can land separately.

Note that this only surfaces the permissions, they are already in the merged manifest, from AC.

Pull Request checklist

QA

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

Amejia481 commented 1 year ago

As we are getting closer to the release, just to confirm we don't need any extra dependencies?

mcarare commented 1 year ago

No, this does not change the current behavior in any way, it just explicitly mentions in the manifest the permissions required inherited from the package "mozilla.components.feature.prompts".

Amejia481 commented 1 year ago

Thanks for the clarification :shipit: !