mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

Bug 1815306 - Truncate tabs tray title to mitigate scroll performance #28792

Closed jonalmeida closed 1 year ago

jonalmeida commented 1 year ago

We truncate the URL as well if we use that, but unlike the url TextView, we do not need to shorten it first.

No tests are needed here for this UI piece which would involve creating/mocking Android Views for limited win. We are transitioning to a Compose tabs tray, so we don't avoid any regressions in this code space.

Co-authored-by: Matt Tighe Co-authored-by: Noah Bond

Before:

https://user-images.githubusercontent.com/1370580/217436451-cfe536f8-4b2e-458a-aa76-3193a8396cfa.mp4

After:

https://user-images.githubusercontent.com/1370580/217436485-cc852ab8-0b37-4d97-8ebf-363d6337956a.mp4

Pull Request checklist

QA

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.