mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

Bug 1814506 - Add unit tests to cover multi selection of tabs #28800

Closed DreVla closed 1 year ago

DreVla commented 1 year ago

Three new unit tests have been added to cover cases when multiple tabs are selected or unselected.

Pull Request checklist

QA

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

DreVla commented 1 year ago

Hey @MozillaNoah I know you are quite busy with tabs tray refactoring and considering that there the code freeze is soon and this is just a simple addition of unit tests, if you have some time, could you please take a quick look so the PR can be merged? Thank you!

DreVla commented 1 year ago

Even though this is approved, since it is code freeze day, we will not land it until after the Fenix migration.

gabrielluong commented 1 year ago

The monorepo team is working to close out opened PRs before the migration and archiving this repo. Since this is just a test change and to help avoid re-applying the changes on the monorepo, I am gonna push this to landing today.