mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.48k stars 1.27k forks source link

Bug #1812430 - No success pop-up/ snackbar is displayed after adding manually a login #28802

Closed gitstart closed 1 year ago

gitstart commented 1 year ago

The PR display an snackbar when a new login is added

Issue video

fnx-64-issue.webm

Demo video after fix

fnx-64-fix.webm

Pull Request checklist

QA

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1812430

firefoxci-taskcluster[bot] commented 1 year ago
No Taskcluster jobs started for this pull request ```js The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the default branch) does not allow starting tasks for this pull request. ```
csadilek commented 1 year ago

Hey @gitstart, Thank you so much for your contribution. It’s much appreciated. Unfortunately, we are in the process of moving this repository to firefox-android early next week, and won’t be able to review or land any PRs until after the migration. Please feel free to reopen a new PR against the new repo once migration is complete. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see https://github.com/mozilla-mobile/fenix/issues/26855.