Closed Alexandru2909 closed 1 year ago
I am approving this since it's soft freeze today. We have already started a discussion around the UX comment I had.
The proposed topic is around whether or not UX wants to persist the proportions within the element when it comes content sizes as a result of situation such as bigger text sizes. If so, then this will challenge how we have been using a fixed height for the container for most of our composables. Instead, we would want the container to wrap the contents.
Put another way, we're wondering if UX expects the proportions of the elements within the container to be maintained. In the screenshot, you will see that we’re using a fixed height container, but situations where the user uses bigger text, then the text content will need to be laid out more dynamically to accommodate the space it has to work with. Alternatively, the container size should be dynamic and just wrap elements within it while maintaining the expected paddings between all of the elements
Using dynamic height for the Pocket stories (Preview) compared to fixed height prior to landing this PR (Nightly)
Thank you for the above video. Make sense that if we remove the hardcoded height than one item can be bigger than the others or many items can have different heights and then we end up with a staggered grid which seems like a worse result to me.
Added
SpaceEvenly
arrangement to sponsored stories details to avoid havingpublisher
text cut-off for normal fonts on some devices.https://user-images.githubusercontent.com/35462038/217870656-c837af13-8c80-4b1e-8a72-045fa6d8dafc.mp4
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-debug
task.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
Used by GitHub Actions.