Bug 1812144 - Homescreen is scrollable even if there is no content

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android

https://github.com/mozilla-mobile/firefox-android

Mozilla Public License 2.0

6.48k stars 1.27k forks source link

Bug 1812144 - Homescreen is scrollable even if there is no content #28813

Closed gitstart closed 1 year ago

gitstart commented 1 year ago

Homescreen Appbar is scrollable even if there is no content, from customize homepage all options disabled and then the appbar is scrolling if you tap on the bar and scroll up.

HomeScreen

Issue Screenshots

fnx-60-issue.webm

Fix Screenshots

fnx-60-fix.webm

Pull Request checklist

[ ] Tests: This PR includes thorough tests or an explanation of why it does not
[x] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
[x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

[x] QA Needed

GitHub Automation Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1812144

firefoxci-taskcluster[bot] commented 1 year ago

No Taskcluster jobs started for this pull request

```js The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the default branch) does not allow starting tasks for this pull request. ```

csadilek commented 1 year ago

Hey @gitstart, Thank you so much for your contribution. It’s much appreciated. Unfortunately, we are in the process of moving this repository to firefox-android early next week, and won’t be able to review or land any PRs until after the migration. Please feel free to reopen a new PR against the new repo once migration is complete. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see https://github.com/mozilla-mobile/fenix/issues/26855.

gitstart commented 1 year ago

Hey @gitstart, Thank you so much for your contribution. It’s much appreciated. Unfortunately, we are in the process of moving this repository to firefox-android early next week, and won’t be able to review or land any PRs until after the migration. Please feel free to reopen a new PR against the new repo once migration is complete. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see #26855.

Okay @csadilek, totally understandable.. will definitely repost the PRs when the MonoRepo is ready. Thank you.