Bug 1815424 - Show Dialog should not be called multiple times. - Githubissues

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android

https://github.com/mozilla-mobile/firefox-android

Mozilla Public License 2.0

6.48k stars 1.27k forks source link

Bug 1815424 - Show Dialog should not be called multiple times. #28815

Closed iorgamgabriel closed 1 year ago

iorgamgabriel commented 1 year ago

Pull Request checklist

[ ] Tests: This PR includes thorough tests or an explanation of why it does not
[x] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
[x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

[x] QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

Click on Checks at the top of the PR page.
Click on the firefoxci-taskcluster group on the left to expand all tasks.
Click on the build-debug task.
Click on View task in Taskcluster in the new DETAILS section.
The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

iorgamgabriel commented 1 year ago

https://user-images.githubusercontent.com/8118371/218069407-e5761316-ab51-4d03-aebe-1f01f699d975.mp4

iorgamgabriel commented 1 year ago

Thank you @t-p-white