mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.48k stars 1.27k forks source link

Bug 1816186 - Use detect-only just when we can show the re-engagement dialog #28824

Closed Amejia481 closed 1 year ago

Amejia481 commented 1 year ago

The platform team brought some concerns of the performance cost of having the detect only mode active while the user can't see re-engagement dialog. They suggested we should keep it active only when the user could see the re-engagement dialog otherwise should be disabled.

This PR disables the feature when the users can't see the re-engagement dialog until waiting time for next time that the dialog could be seem again.

Pull Request checklist

QA

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.