mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] Indonesian domains are incorrectly entered in Fenix tab switcher #3392

Closed reinhart1010 closed 4 years ago

reinhart1010 commented 5 years ago

Fenix tab switcher only lists PANDI-reserved secondary level domains (*.ac.id, *.biz.id, *.co.id, *.desa.id, *.go.id, *.mil.id, *.my.id, *.net.id, *.or.id, *.ponpes.id, *.sch.id, and *.web.id) when the site does not have any subdomain (e.g. <site>.co.id instead of <subdomain>.<site>.co.id or www.<site>.co.id).

ScreenshotUNITO-UNDERSCORE!20190612-235022!UNITO-UNDERSCORE!Firefox Preview!

  1. https://go.com
  2. https://kominfo.go.id
  3. https://www.bi.go.id

Other sites for testcase:

ScreenshotUNITO-UNDERSCORE!20190612-232507!UNITO-UNDERSCORE!Firefox Preview!

  1. http://www.penabur-inter.sch.id
  2. https://almanar.ponpes.id
  3. https://gunungrejo.desa.id
  4. https://kominfo.go.id
  5. http://rekrutmen-tni.mil.id
  6. http://binus.ac.id
  7. http://bpkpenaburjakarta.or.id
  8. https://pandi.id - Official .ID registrar, site is without secondary level domain name

ScreenshotUNITO-UNDERSCORE!20190612-233519!UNITO-UNDERSCORE!Firefox Preview!

  1. https://web.tunnel.my.id
  2. https://good.biz.id
  3. https://www.waroeng.web.id
  4. https://www.indocyber.net.id
  5. https://www.google.co.id

Device information

┆Issue is synchronized with this Jira Task

ekager commented 5 years ago

Are you still seeing this issue? I tried a few of these domains and they looked better than the screenshots above now

reinhart1010 commented 5 years ago

I can now confirm this is fixed, though I have not re-tested all the SLDs.

Screenshot_20190801-133336_Firefox Preview

  1. https://kominfo.go.id/
  2. http://binus.ac.id/
  3. http://student.binus.ac.id/
  4. https://kbbi.kemdikbud.go.id/
  5. https://privy.id/

https://www.google.co.id/ now returns to "google" instead of "google.co".

ekager commented 5 years ago

Thanks! Closing

AndiAJ commented 5 years ago

Hi, verified as fixed on the latest Nightly Build #12240720 from 12/8 using the following devices: • Google Pixel 3a (Android 9) • Huawei Mate 20 Lite (Android 8.1.0) • Samsung Galaxy S7 (Android 7) • OnePlus A3 (Android 6.0.1) • LG Nexus (Android 5.1.1)

Screenshot_20190812-150231