nit: 3 dot menu animation

[Cheap-Skate]

Nit: 3 dot menu is at the bottom, when I tap it the menu animates down from the top like a windowshade. If "falls" from the center of the screen towards the 3 dot menu icon. Instead should it animate up from the bottom i.e. "rise up out of" the 3 dot menu button?

┆Issue is synchronized with this Jira Task

[pocmo]

@Cheap-Skate What device are you using?

[Cheap-Skate]

Galaxy S7 / Android 8.0.0. Sorry

[Sdaswani]

@lime124 to assign to Amy soon.

[lime124]

removing the [UX] so this covers the eng work. we have an issue to track the UX work for animations this milestone.

[AmyYLee]

@Cheap-Skate Hi, can you attach a video capture of the issue you are referring to? I am not seeing this in the reference build @pocmo

Thanks

[Cheap-Skate]

If you turn on Developer Options in Android settings, then set Drawing > Window Animation Scale 10x, can you see it then? The menu drops down to cover the three dots, on my Galaxy s7 at least. I can take a video if you like. It's really a tiny nit pick :)

[lime124]

@AmyYLee see above!

[AmyYLee]

Drawing > Window Animation Scale

Hi,

Yes I set the scale to 10x but I'm unclear on what the issue is. Can you please provide a video? Thanks

[Cheap-Skate]

20190207_120117.mp4.zip

Hi Amy, video attached, this is at Window Animation Scale 10x. At the moment the Settings menu starts near the middle of the screen and expands and drops down to cover the URL bar. It looks like it is expanding out of a point in the middle of the screen. I think this is wrong. I think it should expand out of the three dot menu on the URL bar, so, start small at the bottom right and expand up and to the left to its full size.

[Cheap-Skate]

I did a sketch of current behavior and what I think would be better, sorry for the terrible drawings. I think you need to tweak the animation settings. The current behavior just looks a bit unpolished IMHO.

Cheers!

[colintheshots]

I don't believe there's any animation currently. It's just the normal View painting. We could add a circular reveal animation to match Material Design. Let's put this issue on the backlog to fix in a future Sprint.

[jonalmeida]

@AmyYLee I've taken a video of what's being described in the ticket here with the animations slowed down. @Cheap-Skate can you verify this is what you're referring to?

HQ video

I don't believe there's any animation currently. It's just the normal View painting. We could add a circular reveal animation to match Material Design. Let's put this issue on the backlog to fix in a future Sprint.

A simple override to fade in from the bottom should suffice.

I was playing around with a simple reveal animation from the corner (similar to Chrome) for https://github.com/mozilla-mobile/reference-browser/issues/420 that may work here as well.

[Cheap-Skate]

@jonalmeida yes that's it. On the one hand, I expect most users won't notice. On the other hand, I got the impression that it is easy to fix if you want to go that way.

Of course if you are eventually going to have toolbar top or bottom as a user option you want your animation to cover both cases - drop down from top or rise up from bottom.

Thanks for looking at it.

[AmyYLee]

Hi, I think we should reference native android animations where we can. Please see video attachment. Menu Animation.mp4.zip

[vesta0]

@lime124 what is the status of this bug? Are we waiting for UX or sticking with native Android animations?

[mheubusch]

@vesta0 we are using native animations in this case and wherever possible

[jonalmeida]

Are we waiting for UX or sticking with native Android animations?

This question can be confusing since the default and the suggested are both native animations.

To clarify then, the native Android animation (which @AmyYLee also shared) is that the animation would animate from the bottom.

[AmyYLee]

Are we waiting for UX or sticking with native Android animations?

This question can be confusing since the default and the suggested are both native animations.

To clarify then, the native Android animation (which @AmyYLee also shared) is that the animation would animate from the bottom.

Yes it would animation from the bottom (basically coming out from the 3-dot menu)

[jonalmeida]

This can probably be closed now.

[yoasif]

The animation comes out of the menu for me in the latest Fenix.

[sblatz]

I'm throwing a QA needed label on this :)

[lobontiumira]

Verified as fixed on the latest Nightly build 190704 (#11850611) with Samsung Galaxy Tab S3 (Android 8).