[Bug] Fenix not setting default search engine properly

[boek]

Steps to reproduce

Set locale to RU or CN

Expected behavior

Default search engine is not Google

Actual behavior

Default search engine is Google

Device information

any

┆Issue is synchronized with this Jira Task

[AndiAJ]

Hi, I can still reproduce this issue on the latest Fenix Build #11850611 from 4/7 using a Google Pixel 3XL (Android 9) as it follows:

Russian ✅ OK - Yandex

► **Settings:**  ► **Fenix default search engines:** 

Chinese Traditional 1st option ❌NOK - Google

► **Settings:**  ► **Fenix default search engines:** 

Chinese Traditional 2nd option ❌NOK - Google

► **Settings:**  ► **Fenix default search engines:** 

Chinese Traditional 3rd option ❌NOK - Google

► **Settings:**  ► **Fenix default search engines:** 

Chinese Standard 1st option ✅ OK - Baidu

► **Settings:**  ► **Fenix default search engines:** 

Chinese Standard 2nd option ❌NOK - Google

► **Settings:**  ► **Fenix default search engines:** 

Chinese Standard 3rd option ❌NOK - Google

► **Settings:**  ► **Fenix default search engines:** 

Chinese Standard 4th option ❌NOK - Google

► **Settings:**  ► **Fenix default search engines:** 

@boek For each of the above mentioned languages you'll find attached pictures from the device settings as well as from Fenix. Also, I'm not sure if for each Chinese language (Traditional or Standard) and their options should be also covered?

[boek]

Pt 2 waiting on: https://github.com/mozilla-mobile/android-components/issues/3637

[liuche]

Half of this has been done and fixed, but waiting for more permanent location search-engine from AC.

Will remove from sprint.

[k0st1x]

How to use the eng language on device but use the Yandex search?

[pocmo]

In AC 10.0.0 we landed RegionSearchLocalizationProvider which does a GeoIP lookup to determine the region and is more accurate than locale. In order to use that we need to make sure that Fenix is only using "async" methods of SearchEngineManager since it may do a network request if no region is cached.

[boek]

Waiting on an MLS api key

[severinrudie]

@boek since this was moved into the backlog, does that mean that the key is now available? Where would I find it?

@pocmo if RegionSearchLocalizationProvider checks my current location, is there a way for me to verify RU and CN behavior without booking a flight?

@vesta0 to clarify requirements, is it expected that users who are currently in China use Baidu by default, or that users who have selected a Chinese locale use Baidu by default? Because these will require different approaches.

[severinrudie]

boek since this was moved into the backlog, does that mean that the key is now available? Where would I find it?

I spoke with boek, and it looks like we've requested the key but haven't heard back yet. We will refactor our SearchEngineManager calls to use the async API now, so once we get the key we can quickly drop it in.

[vesta0]

@Baron-Severin to answer your question, we currently reference the system default locale so if a user's system default locale is zh-cn then their search engine default will be Baidu.

Once #220 is shipped, then user can change their locale but I believe search engine default will regardless follow the locale.

cc @mconnormoz in case further clarification needed

[severinrudie]

We expect that changes made in #5577 will fix this bug as well.

[severinrudie]

We expect that changes made in #5577 will fix this bug as well.

Correction, these changes did a lot of the prework that will enable this fix, but didn't actually fix the behavior. Moving this into the backlog, as it still needs to be done.

[abodea]

Hello, @boek @vesta0 is there a list where I can see what default search engine should be displayed for each language? I synced with Severin on slack but he couldn't help me. Note that for Chinese Traditional now is not Google displayed, but it's Bing. Before moving forward with the verification I wanted to make sure I have the right list for each language. I will remove the qa needed until further notice.

[liuche]

@flod do you know where the default search engine is listed per-locale?

[vesta0]

Can we find out which devices or locales are impacted by this bug?

[sv-ohorvath]

@vesta0 Does this need QA investigation? If so, we could add the QA:needed label and have someone look at it.

[liuche]

This seems like the same STR as #12544 which was verified, so I'm going to close this as a dupe