Seamless Lockwise integration in Fenix for existing Lockwise users

lime124 commented 5 years ago

User Story

As a Lockwise user, I want to have a seamless integrated experience when using Fenix with Lockwise, so I can use them together and get the most out of having a Firefox account.

Acceptance Criteria

I can use Lockwise with Fenix.
I have a seamless experience (minimize transitions, alerts, etc)
I am not confused about similar Fenix or Lockwise features (e.g. double prompt)
I want to be able to find my logins in Lockwise if autofill doesn't work.

Dependencies

[ ] Lockwise login improvement work is finished

Design Work

[ ] Request for Comments from UX team
[ ] N/A Usability testing if a new pattern or potentially confusing UI
[x] Request for Comments from Fenix team and/or A/C, GV, Sync, etc as needed
[x] Interaction details included
[ ] N/A Accessibility - is this a review by someone, just keeping it in mind?
[x] For existing UI changes, details are highlighted
[x] Strings/content reviewed and approved
[ ] Are they too long for the component in other locales

Deliverable

[x] Assets uploaded to Google Drive
[x] Links to deliverables (spec, assets) posted in comment 0

Deliverable Links

UX Spec Assets

┆Issue is synchronized with this Jira Task

sandysage commented 5 years ago

When I'm using Fenix, and need to investigate what logins I have saved/synced from Firefox (potentially because a login did not autofill the way I expected), I want to know where to get my Firefox saved logins AND get started using them going forward.

Acceptance criteria

should work towards an integrated experience for the most seamless user experience (ie minimize transitions/popups/alerts/etc.)
should be able to download Lockbox from Fenix
should be able to open Lockbox from Fenix
should be contextual only be accessible from the existing "logins" flow (currently in Library)

sandysage commented 5 years ago

We may need another follow up issue for this user story: When I'm using Fenix, and get to a login form for one of my online accounts, I want to know how to use my Firefox saved logins to fill in login forms.

changecourse commented 5 years ago

I'm not sure what you mean in the latest comment, @sandysage. Can you please clarify if this is still pertinent based on the latest InVision flow?

sandysage commented 5 years ago

@changecourse When I go to twitter in my new Fenix browser, and I'm already signed into my Firefox Account, my current expectation is that the credentials I save in Firefox would automatically populate the username and password fields on the website. I maybe don't yet know I need to find Library -> logins to troubleshoot why my saved credentials aren't working. Is there anything we can/should introduce on the login form itself as a future story?

changecourse commented 5 years ago

ah, fair... similar to how we handle the identified UN/PW fields for autofill with "Search Firefox Lockbox" within it, but instead of seeing that, some form of promo for "use firefox saved login" or equivalent to launch the promo overlay?

@sandysage yes, let's add as a separate issue to handle.

lime124 commented 5 years ago

Amy and I met with Nick and Ryan last week to go over proposed flows/UI. Amy will work continue to iterate on the final UI designs in preparation for dev.

bbinto commented 5 years ago

While I <3 the idea, and wish we could have this for MVP, I'm worried about other must haves - @lime124 - I don't think this is mandatory for MVP tbh - I feel Amy could/should pick up other UX issues in the meantime. See my comment here: https://github.com/mozilla-mobile/fenix/issues/87#issuecomment-472390978

lime124 commented 5 years ago

Moving this out of the MVP work for UX.

lime124 commented 5 years ago

@vesta0 - amy mentioned this was a desired phase two after the login manager work she's during now. do we want to put this in to the ux backlog to tackle in the near future?

vesta0 commented 5 years ago

Thanks @lime124 yes I raised it to Amy to make sure that she is aware of it (to ensure design alignment) but it's more of a could for Q4.

lime124 commented 5 years ago

perfect - thanks!

liuche commented 4 years ago

@sandysage @lime124 I split this into 2 issues (#5498) so we can better address these two situations, because they can be done in parallel.

vesta0 commented 4 years ago

Updated the description.

ekager commented 4 years ago

Hi @jhugman @eliserichards if we want to deep link directly to a login to edit in Lockwise by some sort of ID is that something that would be possible in Lockwise? Is there a shared ID because we are both pulling from sync? @AmyYLee was asking as part of the design process.

mnoorenberghe commented 4 years ago

Is there a shared ID because we are both pulling from sync?

Each login has a GUID which is persistent. It's ServerPassword.id in the Rust login library.

mozilla-mobile / fenix