Closed cadeyrn closed 4 years ago
We'll take a look. There appear to be an increasing number of leaks lately.
I have two new LeakCanary reports with ReportFragment and HomeActivity involved. While the previous reports were "never GCed but no leak detected" reports, this time the reports are "excluded leak" reports.
Fenix version: Fenix revision 8b793cd43ea0b816fece4266c2dbc990e24ceae1
New leaks, again different ones:
Now I have STR to reproduce one kind of these leaks:
This works in 100% for me to cause a HomeActivity and a ReportFragment leak.
The number of leaks increased noticeably - there are now leaks on more places. But I can no longer find the LeakCanary app on my device so I can't share any reports.
@cadeyrn @colintheshots are these reports still happening?
@sblatz Yes, LeakCanary is still reporting leaks (build from 7/12, I can test with latest version from master tomorrow). Unfortunately I can't find the LeakCanary app in my apps anymore so I don't know how I can share more details. :-/
Retested with latest build from master (revision 95367c2b50ea16cd853e215587c0871c1ebc163b).
The following steps still always trigger a leak:
Why is there no Leaks launcher icon produced by Firefox Fenix? And why does, every time a Fenix leak analysis is completed, it's deleted immediately from my Downloads/leakcanary-org.mozilla.fenix.debug
folder, leaving it empty? Is this normal behavior (leak reports are uploaded online and deleted), or not?
I'm not able to reproduce the original LeakCanary report found here. I spent a bit of time playing around with the app and found very few leak reports (when running monkey). I think we should punt on this ticket for now as none of them seem super critical.
I'm not able to reproduce the original LeakCanary report found here.
Did you try the steps from here? https://github.com/mozilla-mobile/fenix/issues/747#issuecomment-512470049
Because this is still reproducible in 100% for me.
We'll look at this in a future sprint, since there are fewer reports than when this was first filed and leaks were a huge problem.
@kbrosnan and @rpappalax can also look into this because getting leak testing into our UI tests is very important.
There is now also a leak when opening a custom tab and then pressing the back button.
Retested with latest build from master (revision 95367c2).
The following steps still always trigger a leak:
1. press the mask icon on the Fenix home screen to launch private mode 2. repeat step 1 to leave private mode 3. repeat step 1 again
The leak is still present but with the new LeakCanary version the user interface is finally back so I can share more details.
Download .hprof file: https://drive.google.com/open?id=13dnKqhDJxrlCnOELzG1xb7xJTnxHEqeB
I can no longer reproduce the reported leaks and #8619 seems to fix some leaks. Maybe it's time to close this issue? Or are there still some known leaks?
Let's close this issue I think #8619 #10033 and #10012 addressed most of the found leaks.
A good follow-up is https://github.com/mozilla-mobile/fenix/issues/4506 to prevent future memory leaks.
What
We have reports of a memory leak and we should fix memory leaks because they lead to out-of-memory crashes.
Impact
If we do not resolve this issue, there's a chance the user crashes. These are easy to detect as shown below.
Acceptance criteria
I got two LeakCanary reports.
I attached a ZIP with the two .hprof files.
archive.zip
Device information
┆Issue is synchronized with this Jira Task