mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug]The user can initiate multiple installations of Ublock Origins #8304

Closed AndiAJ closed 4 years ago

AndiAJ commented 4 years ago

Steps to reproduce

  1. Navigate to the Add-ons manager
  2. Tap the '+' (install button) and confirm the addition
  3. While the installation and verification is performed, tap the device back button
  4. Open again the Add-ons manager
  5. Tap the '+' (install button) and confirm the addition

Expected behavior

The user should not be able to initiate multiple installs of the same Add-on.

Actual behavior

The user can initiate at least two installs of the same Add-on. (depending on the device used, for instance on the LG Nexus 4 the user can initiate 6 consecutive installs of uBlock )

Device information

Notes

Seems to be a regression of #8167 with a slightly different STR.

► Video from Huawei Mate 20 Lite 20200211_111821

► Video from LG Nexus 4 20200214-134546

┆Issue is synchronized with this Jira Task

csadilek commented 4 years ago

@AndiAJ we landed a fix for this today to make sure the add-ons screen always shows the correct state. Can you please verify again?

Note that an ideal UI would have some persistent progress indicator of installation which we could show instead when coming back, but we don't have any support for that in GV/A-C and it's out of scope right now. I will discuss with UX and file a follow-up as needed.

AndiAJ commented 4 years ago

Hi, verified as fixed on the latest Nightly #20430607 from 2/12using the following devices: • Google Pixel 3a XL (Android 10) • Google Pixel 3a (Android 9) • Huawei Mate 20 Lite (Android 8.1.0) • Samsung Galaxy S7 (Android 7.0.0) • OnePlus A3 (Android 6.0.1) • LG Nexus 4 (Android 5.1.1)

► Video from Huawei Mate 20 Lite 20200212-111229