search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] Search engine settings are not stored #8552

Closed ColourGrey closed 4 years ago

ColourGrey commented 4 years ago

There are three misbehaviours in the "Settings > Search" menu item, but I believe them to be caused by a single bug, so I shall document all of them here.

First issue:

I had customized the list of search engines to my needs. Installing Nightly 200219 (build 20500607) reverted it to the default one, without announcing me of it or asking for my permission, making me lose the customization.

Second issue:

Delete some of the search engines. Go back to the "Settings" menu. Now enter the "Search" menu item again. The deleted engines are there again, they haven't really been deleted.

Third issue:

Tap on "+ Add search engine" and add any of the search engines found there. Go back to the "Settings" menu. Now enter the "Search" menu item again. The added engines aren't there, they haven't really been added.

Device information

┆Issue is synchronized with this Jira Task

kbrosnan commented 4 years ago

In the future please make separate issues for each individual item. Having more than one problem per issue makes it harder to correctly resolve the issue.

The second item is #8526

boek commented 4 years ago

I agree, luckily the same fix should fix all three issues. I will verify that and explain what is ready to QA 👍

sv-ohorvath commented 4 years ago

All 3 issues, including the one in #8526 are verified as fixed on Nightly 2/24.