mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

Firefox's Password Manager should work with HTTP authentication dialog #8642

Closed yookoala closed 3 years ago

yookoala commented 4 years ago

Why/User Benefit/User Problem

It works on Firefox desktop and the Fennec. And it is kind of expected by users.

What/Requirements

Password Manager should work to remember HTTP authentication username / password just as it does for normal HTML login forms.

Acceptance Criteria (how do I know when I’m done?)

  1. If a password of the HTTP authentication site is in the Password Manager, Fenix should display the suggested username and password on the popup login dialog.
  2. If a password of the HTTP authentication site is NOT in the Password Manager, Fenix should wait until user entry then ask if she / he wants to store the login information to the Password Manager.

┆Issue is synchronized with this Jira Task

yookoala commented 4 years ago

A duplication of #4992. Close now.

ekager commented 4 years ago

I'm reopening this because it is about the internal password manager working with HTTP Authentication Dialogs and different than #4992

TroelsS commented 4 years ago

More info on this bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=993902

TroelsS commented 4 years ago

I do not think it is a "feature request" but rather a bug.

This worked fine in Firefox 68.0.1.

fichtennadel commented 4 years ago

see also https://github.com/mozilla-mobile/fenix/issues/9257

yookoala commented 4 years ago

Still doesn't work when it rolled out 😟

TroelsS commented 4 years ago

@ekager Shouldn't this be labeled as a bug?

mpopp75 commented 4 years ago

This clearly is a bug and should be given higher priority.

Antagony1060 commented 4 years ago

Why is this still flagged as a ‘feature request’? It is clearly a bug as the behaviour has regressed between versions.

This is a real pain for me as I use HTTP authentication extensively for testing and I don't want the hassle of having to fire up my separate password manager every time I want to check them via a mobile device.

Dunexus commented 4 years ago

Fenix is a entire rewrite of the browser around GeckoView. As this feature has not been implemented in Fenix, it is a feature request (code that need to be written) and not a regression (code that worked and doesn't anymore). The labels are from a developer's point of view to help them knowing where to look. This labeling choice is not used to deny the fact that this feature was present in Fennec (old-firefox) and has not been ported yet.

WeirdConstructor commented 4 years ago

From a user perspective this is a regression, as I just used to use Firefox on my mobile and from one day to the next it stopped working. Wish I could go back to the older Firefox version easily. As developer I understand that this is a feature "request" in case of a rewrite. As user I don't understand why a rewrite was necessary in the first place. And it breaks something I use on a daily basis. So I might have to go back to chrome for now.

Antagony1060 commented 4 years ago

From a user perspective this is a regression, as I just used to use Firefox on my mobile and from one day to the next it stopped working.

Quite so @WeirdConstructor. The obvious concern for those of us objecting to the labelling/handling of this issue is that as a ‘feature request’ it will no doubt have a lower priority and therefore either take a long time to get fixed or may be ignored altogether. The very fact it still has no assignee fully seven months after it was opened would seem to vindicate that fear.

aslmx commented 4 years ago

This is still the case in recent Firefox builds. It stopped working a few months ago, all of a sudden.

I wish this could be given the appropriate BUG label (or regression, as it has been pointed out often enough that this has worked just fine before) and priority.

It is utterly annoying.

yookoala commented 4 years ago

This is still the case in recent Firefox builds. It stopped working a few months ago, all of a sudden.

I wish this could be given the appropriate BUG label (or regression, as it has been pointed out often enough that this has worked just fine before) and priority.

It is utterly annoying.

@aslmx

On July this year, the official release of "Firefox for Android" has switched from the old Fennec to a completely rewritten one, codename Fenix. Since this is a complete rewrite, the development team considers this previously Fennec-supported feature as a "new feature" in Fenix.

This is a bit ridiculous in users' perspective, but this is why this issue is not labelled a "bug".

gusowski1 commented 4 years ago

But from an user perspective it is a bug and a reason to switch the browser to get things working as expected. I switched my primary mobile browser because of this reason weeks ago and up to now i didn't switched back cause of several things not working anymore.

I understand the behavior from a developer perspective - but from the userpoint it is a nogo. But it is a good way to lose more and more users. But probably mozilla's user base has grown in sum within the last month more as the lose of old fennec users cause of the switch from fennec to fenix.

Am Mi., 7. Okt. 2020 um 14:50 Uhr schrieb Koala Yeung < notifications@github.com>:

This is still the case in recent Firefox builds. It stopped working a few months ago, all of a sudden.

I wish this could be given the appropriate BUG label (or regression, as it has been pointed out often enough that this has worked just fine before) and priority.

It is utterly annoying.

On July this year, the official release of "Firefox for Android" has switched from the old Fennec https://wiki.mozilla.org/Mobile/Fennec to a completely rewritten one, codename Fenix https://github.com/mozilla-mobile/fenix. Since this is a complete rewrite, the development team considers this previously Fennec-supported feature as a "new feature" in Fenix.

This is a bit ridiculous in users' perspective, but this is why this issue is not labelled a "bug".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla-mobile/fenix/issues/8642#issuecomment-704912963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOI3SGRYRF5VW2NCAJZEUTSJRPZBANCNFSM4KZGNA4A .

yookoala commented 4 years ago

@gusowski1: No objection here. I think this is a bug / regression for me.

Hubfront commented 4 years ago

It's a bug, if the internal password manager can't handle basic authentification.

I guess, the reason for lazy developers to mark bugs as low priority "feature request" is, to have no pressure to touch or fix it.

Weird enough, until august 2020, it wasnt possible with fennec/fenix to even login into websites using the internal password manager. Although also clearly a bug, this was marked too as a feature request and took a year, until someone did bother to fix it, see #5551. How should firefox catch up with chrome, regarding usage share, if basic functionality isnt working for years?

riksoft commented 4 years ago

I confirm this huge bug is still in any firefox for Android available, even on the nightly. This bug forces the user to retype user/pass every time.

Apparently there is also another bug that prevents the workaround of passing user/password via url in the form user:pass@host that is a standard working on firefox desktop or any other browser mobile.

Hubfront commented 4 years ago

@riksoft Thats right. Firefox devs need to know, if they bother at all: it's not possible to copy the login credentials from the login credential page of fenix, because the login prompt will be gone already if you got back to the basic auth page. Simply reloading wont help either, because fenix wont bring the prompt back again, until you close the browser entirely with all opened tabs and sessions, and till you open the basic auth page again to insert the login credentials. But then you have only a copy of one of the two credentials: user or pass. If you choose to copy the password, what most of us will probably do, because the pass should be not easy to remember, you need to remember the username from the brain in order to fill it in the login prompt, paste the passwort to get finally logged. If a basic functionality is not working, it's a bug, not a feature request.

Maybe developement thinks, that we expect too much and that we should be thankful, that the internal passwort manager of fenix is able to fill in the appropriate login credentials when other authentification methods are used, at least after one year of "feature request" it was fixed in August 2020 ... well, if the mozialla team really wants firefox to catch up with chrome, they should probably fix at least the important bugs earlier, that prevent basic functionality, like log in in a website with user/pass , than they did in the past.

Hubfront commented 4 years ago

No one assigned after 9 months. Same is the case for the bug that addresses autofill of http auth dialog by 3rd party password manager.

Thats how you build non-competitive software.

WeirdConstructor commented 4 years ago

I am kind of relieved that I am not the only one relying on basic auth. And I also tried http://user:pass@domain/... - Chrome handles all this a little bit better.

I don't believe there is any malicious intend with the priority of this bug or missing feature. Developers are usually trying their best, but are all bound to the resources and time that are allocated for them to work on issues/tasks. For some that is time they are paid to work on it, and for some it's time they are willing to invest without any compensation.

ekager commented 4 years ago

@Hubfront this is a warning that your behavior here is not acceptable. Please familiarize yourself with the CPG if you would like to interact with the team in this repo.

I have filed a Bugzilla ticket to discuss options here if you would like to follow along. https://bugzilla.mozilla.org/show_bug.cgi?id=1676216

@riksoft Please open other bugs in new tickets, I'm not sure I understand your comment above about pasting

Hubfront commented 4 years ago

Its not my intent to get on someones nerves. I wish to fenix to get a better browser. It gets on my nerves, if i cant log in.

ekager commented 4 years ago

And I hear you that it gets on your nerves, but it is never helpful or acceptable to use language like "lazy developers" and "Thats how you build non-competitive software".

We have a very small team and almost 3k open issues. I'm sure everyone thinks the issue that bothers them the most is the most important.

Hubfront commented 4 years ago

I use firefox since some time and trust the team and their integrity more than the ones of other browser companies. I appreciate your work.

riksoft commented 4 years ago

@ekager "I'm not sure I understand your comment above about pasting" I said "passing". To work around this problem I tried an intermediate page as a redirect to the target auth page, and this intermediate page was passing (get instead of post) a url in the form of user:pass@host. Unfortunately that doesn't work either (despite the desktop version of Firefox, and any other mobile browser work ok both with basich auth and this kind of URL).

I can't wait till this bug will be eventually solved, so I've though another way to work around this problem and I've found one perfect for my case. Hope this could be of use to others: I've "whitelisted" the LAN IPs in the same .htaccess used for the basic auth, so I can skip the authentication altogether when I'm accessing the page from the LAN or via SSH from remote.

AuthType Basic AuthName "Secure Area" AuthUserFile /xxxxx/xxxx/.htpasswd Require valid-user Require ip 192.168.0

That's not OK for any situations (e.g. not for a website accessed directly via http) but for local servers or http via SSH can do the job.

aslmx commented 4 years ago

I've "whitelisted" the LAN IPs in the same .htaccess used for the basic auth, so I can skip the authentication altogether when I'm accessing the page from the LAN or via SSH from remote.

I am doing exactly this for many years now, so that i don't have to fiddle around when i'm at home (or at work, where i SSH tunnel into my home network anyway).

However, this does not help in all cases. E.g. sometimes the WiFi seems active, but still Firefox (Android) asks me for basic auth. The connection seems to be stuck on mobile data then. This might be a problem of my smartphone, but anyways... This is just a workaround no solution.

I'm almost thinking about using client side certs to protect my selfhosted services. But i wouldn't really expect this to be working flawlessly when basic auth credentials can neither be stored nor be passed via URI...

Hubfront commented 4 years ago

@riksoft tx for sharing your workaround with us. You mentioned also, that any other mobile browser can both handle basic auth and passing the credentials via url like user:pass@host. fenix should be able to handle passing the credentials via url for basic auth too, as its a commonly used method of http 1.1 protocol. For the average user both methods have to work to make him happy.

For a student trying to access an restricted document on the server of his university, its frustrating to have all these credentials in the firefox database but they are useless, because the internal passwort manager cant use them when basic auth is used. In order to keep firefox for Android competitive and attractive having autofilling and storing credentials working is essential for user experience.

See also https://tools.ietf.org/html/rfc7235

riksoft commented 4 years ago

@aslmx @Hubfront No doubt that mine is just a desperate workaround for personal stuff: I can't wait months or years for the real solution. However Firefox mobile should surely manage standard protocols like basic auth or the url user:pass@host.

aslmx commented 3 years ago

Almost another 8 weeks passed. I'm away from my LAN over christmas and everytime i access webpages hosted at home, I hit the .htaccess basic auth. I'm seriously annoyed.

If we can't get a date for the fix, can we get a date when this will be decided?

Hubfront commented 3 years ago

Almost another 8 weeks passed. I'm away from my LAN over christmas and everytime i access webpages hosted at home, I hit the .htaccess basic auth. I'm seriously annoyed.

If we can't get a date for the fix, can we get a date when this will be decided?

Merry christmas to you. I would expect it to be fixed in Q1, thats what Eugen Sawin said. He works since 7 years for Mozilla and seems to have some influence in the developent team.. If we would see some progress in January on this would be gladly appreciated.

Hubfront commented 3 years ago

Any update on basic authentification?

Hubfront commented 3 years ago

When will someone fix this bug?

aslmx commented 3 years ago

I'll prepare a shopping list for a birthday cake... this issue is turning 1 in a few days...

FFranta commented 3 years ago

Wow finally I was able to find I am not alone with this problem. I think I have the problem since about August 2020. Do you have any information about when it could be fixed? Thanks.

ekager commented 3 years ago

Sorry for the frustration. Please follow along in the Bugzilla bug since this cannot be fixed in Fenix alone https://bugzilla.mozilla.org/show_bug.cgi?id=1676216

yookoala commented 3 years ago

Sorry for the frustration. Please follow along in the Bugzilla bug since this cannot be fixed in Fenix alone https://bugzilla.mozilla.org/show_bug.cgi?id=1676216

It's good to know that the issue is on some kind of the Q1 roadmap. Thanks Eugen for working on it and @ekager for updating. As a long time Firefox user, all I hope for was some updates. I believe you're doing things as fast as can be.

Hubfront commented 3 years ago

Sorry for the frustration. Please follow along in the Bugzilla bug since this cannot be fixed in Fenix alone https://bugzilla.mozilla.org/show_bug.cgi?id=1676216

There isnt an update since three months. This bug is open more than a year.

eliserichards commented 3 years ago

Looks like this is on the GV docket for Q1! We might consider closing this bug in favor of a fresh one once that work is done.

Hubfront commented 3 years ago

I would prefer to leave this bug open. If its closed, then it would be harder for us end-users to express our concern, that this bug is still not fixed in reality.

Hubfront commented 3 years ago

How will firefox be competitive with chrome, if the devs cant even fix the password manger to work with basic authentification?

majurgens commented 3 years ago

I also want this "feature". Depending on how problematic it is for you you could revert to using Firefox mobile 68, which is what I am now considering doing

yookoala commented 3 years ago

Looks like this is on the GV docket for Q1! We might consider closing this bug in favor of a fresh one once that work is done.

@eliserichards: Sorry to be a bit pushy, but is there any news on any progress? As you mentioned before, this should be on GeckoView docket for Q1. It's close to the mid-Q2, has any developer picked this up yet? 🙏🏻

Hubfront commented 3 years ago

When will the reluctant developers fix this bug?

susuper commented 3 years ago

It was a super-feature of mobile FF. Looks like the developers have lost a link with the reality a bit(

Hubfront commented 3 years ago

Why do i use firefox? Its not so much about features, though i like the many addons and the fast renderer, wether its desktop or its android. I trust the integrity of the organisation. So all my passwords are stored in firefox since many years. It was therefore important to me, but i bet for many users too, that mozilla finally fixed the password manager in mid 2020, so that he can now use multiple logins in android firefox in standard scenarios, like login to yahoo or to email sites, but i believe it would be also important to many students out there, that android firefox would be able to handle its multiple logins in basic authentification scenarios too, because basic auth is something thats being used often in university environments.

FFranta commented 3 years ago

That is why I used Firefox until yesterday as well. Yesterday Firefox came with new android app design instead of fixing this bug which is there for more than a year. Since yesterday I have been using Chrome and everything is ok - all passwords, bookmarks etc were imported correctly and PC/mobile sync works, as well as passwords stored for basic http authentication. I was waiting paitiently for 16 months, hoping someone will fix it.

Hubfront commented 3 years ago

Its not good for the competitivity of android firefox, that android chrome can handle multiple logins with basic auth while android firefox still cant - it cant even handle stored logins at all with this auth method. The use of multiple logins is a must have / core ability for mobile browsers since several years and firefox still lacks support for it with basic auth. I still dont get it, that the password manager wasnt able till August 2020!!! https://github.com/mozilla-mobile/fenix/issues/5551 to use multiple logins. Almost everybody has multiple logins to many sites. How could mozilla really think so many years, this would not be an important bug? How many users where switching to chrome till mid 2020, because they couldnt use their stored logins on yahoo at all, and instead had to manually type in their username and password (which are often very complicated) in the web login form of their email provider to check their emails lol or to log in to a forum? The most new users to android firefox did that probably one time at all and then switched frustrated to chrome. There were probably not so many users who need that ability and stayed with firefox or even tried on github to get devs to fix it.

dia-de-muertos commented 3 years ago

Any news on this? Is work in progress? I'm still on firefox 68.11, but it's getting more and more dangerous, as it's doesn't get security fixes :-(

ocroquette commented 3 years ago

I also want this "feature". Depending on how problematic it is for you you could revert to using Firefox mobile 68, which is what I am now considering doing

Do you know a reliable source to get Firefox mobile 68 and this feature back ?