mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] Dynamic Nav Bar leaves white space on certain websites #8768

Closed serovar closed 4 years ago

serovar commented 4 years ago

Steps to reproduce

Go to your feeds on feedbin.com and scroll down

Expected behavior

The bottom nav bar hides itself leaving way for the webpage content.

Actual behavior

The bottom nav bar hides itself but leaves a white space.

Device information

screen

┆Issue is synchronized with this Jira Task

erperejildo commented 3 years ago

still facing the same issue. Can't see footer unless I scroll down

xcjs commented 3 years ago

I can confirm this is still an issue when the navigation bar is on the top. Web pages still render as if the bottom bar is present, especially if they have a "sticky footer". Firefox on Android is not calculating the viewport size correctly, and hasn't since the option to display the address bar on the bottom was released.

@sv-ohorvath What's needed to reopen this issue?

thomasaarholt commented 3 years ago

I too would like this issue reopened.

TrissieTheHusky commented 3 years ago

4D6576A4-4FA0-45EA-8F9D-3C938FC6F3D2 Same. I run IOS Firefox. My website has a white space at the bottom and me using Firefox a majority of the time. Really think this should be addressed/Fixed. Edit: I can confirm that it is not my css it is indeed Firefox mobile, it works fine on safari.

hiikezoe commented 3 years ago

I can confirm this is still an issue when the navigation bar is on the top. Web pages still render as if the bottom bar is present, especially if they have a "sticky footer". Firefox on Android is not calculating the viewport size correctly, and hasn't since the option to display the address bar on the bottom was released.

@sv-ohorvath What's needed to reopen this issue?

Opening a new issue with at least one site you can see the issue would be nice. A simple test case would be much appreciate. Thanks!

oalfred commented 3 years ago

I wanted to add here that I have the same problem when zooming in on an image, and it happens regardless of if the tool bar/address bar is at the top or at the bottom.

Steps to reproduce:

Screenshot, note the white area above the touch controls: Screenshot_20210908-150245_Firefox

adrianvincent91 commented 2 years ago

After some debugging, this problem seems to occur when 'overflow: hidden' is added to document.body. As a temporary fix, I'm adding an alternative class to the body when I detect Firefox Android.

body.overflowHiddenFirefoxMobile {
        position: fixed;
        top: 0;
        left: 0;
        right: 0;
        bottom: 0;
}
greddyz commented 2 years ago

I`m fixed it for Firefox Android add rule "top:100%"

.nav { position: fixed; top: 100%; left: 0; right: 0; bottom: 0; }