search

mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show
Mozilla Public License 2.0
25 stars 12 forks source link

Allow Proguard to remove unused @JavascriptInterface with WebView #206

Closed psymoon closed 5 years ago

psymoon commented 5 years ago

Generated in the default proguard-rules.pro. Uncomment https://github.com/mozilla-mobile/firefox-tv/blob/master/app/proguard-rules.pro#L23

mcomella commented 5 years ago

@psymoon Is this to remove unused @javascriptInterface or to prevent unused methods, e.g. like the ones in @javascriptInterface from being removed?

In any case, this seems fragile (need fully-qualified class names of classes with @JavascriptInterface so if it's working now without these lines of code, I'm hesitant to add them.

mcomella commented 5 years ago

Trying to close on FFTV: https://github.com/mozilla-mobile/firefox-tv/issues/1705 Will follow suit here.

mcomella commented 5 years ago

Closing like the Fire TV issue: see there for details.