mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show
Mozilla Public License 2.0
25 stars 12 forks source link

Closes #72: Upgrade to SDK 28 #233

Closed mcomella closed 5 years ago

mcomella commented 5 years ago

Pull Request checklist

mcomella commented 5 years ago

Not ready for review: forgot to upgrade support library versions.

mcomella commented 5 years ago

Ready for review.

codecov-io commented 5 years ago

Codecov Report

Merging #233 into master will decrease coverage by 0.04%. The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
- Coverage      33.9%   33.86%   -0.05%     
- Complexity      358      376      +18     
============================================
  Files           121      123       +2     
  Lines          3224     3417     +193     
  Branches        506      554      +48     
============================================
+ Hits           1093     1157      +64     
- Misses         2030     2159     +129     
  Partials        101      101
Impacted Files Coverage Δ Complexity Δ
...ozilla/focus/widget/AccessibleGridLayoutManager.kt 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...illa/focus/toolbar/UrlBoxBackgroundWithProgress.kt 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...w/java/org/mozilla/focus/webview/FirefoxWebView.kt 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...in/java/org/mozilla/focus/home/HomeTilesManager.kt 5.81% <0%> (-0.07%) 0 <0> (ø)
...main/java/org/mozilla/focus/toolbar/ToolbarText.kt 90% <0%> (-10%) 5 <0> (ø)
app/src/main/java/org/mozilla/focus/ext/Uri.kt 100% <100%> (+9.52%) 0 <0> (ø) :arrow_down:
.../main/java/org/mozilla/focus/utils/ToastManager.kt 100% <100%> (+100%) 5 <1> (+5) :arrow_up:
...rc/main/java/org/mozilla/focus/FocusApplication.kt 75% <0%> (-3.27%) 4% <0%> (+1%)
.../java/org/mozilla/focus/browser/BrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
...org/mozilla/focus/architecture/ViewModelFactory.kt 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6973839...c3cd12c. Read the comment docs.

mcomella commented 5 years ago

Unresolved Sentry issue doesn't seem blocking: I'm going to land.