mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show
Mozilla Public License 2.0
25 stars 12 forks source link

Closes #219: When exiting fullscreen, defer removing windowBackground. #242

Closed mcomella closed 5 years ago

mcomella commented 5 years ago

Pull Request checklist

codecov-io commented 5 years ago

Codecov Report

Merging #242 into master will increase coverage by 0.15%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     34.67%   34.83%   +0.15%     
  Complexity      370      370              
============================================
  Files           123      122       -1     
  Lines          3247     3264      +17     
  Branches        507      513       +6     
============================================
+ Hits           1126     1137      +11     
- Misses         2023     2026       +3     
- Partials         98      101       +3
Impacted Files Coverage Δ Complexity Δ
...org/mozilla/focus/architecture/ViewModelFactory.kt 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...pp/src/main/java/org/mozilla/focus/ext/LiveData.kt 87.5% <0%> (-5.84%) 0 <0> (ø)
...pp/src/main/java/org/mozilla/focus/MainActivity.kt 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../java/org/mozilla/focus/browser/BrowserFragment.kt 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...java/org/mozilla/focus/browser/BrowserViewModel.kt 89.28% <82.35%> (-10.72%) 6 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e57ef6...4357474. Read the comment docs.

mcomella commented 5 years ago

In debugging an unrelated issue, I discovered I could move the code to the BrowserFragment which better encapsulates it than keeping it in the MainActivity. I made the move and force-pushed my code. Over to @Baron-Severin to verify this approach is acceptable.

mcomella commented 5 years ago

Closing this PR: sorry, Severin, I found a better solution. Apparently the stuttering issue was being caused by us translating the WebView while it was exiting fullscreen to make room for the toolbar. We can more simply fixing the toolbar by disabling this animation, which was already pretty janky anyway.