mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show
Mozilla Public License 2.0
25 stars 12 forks source link

No issue: add device resolution to device reference. #248

Closed mcomella closed 5 years ago

mcomella commented 5 years ago

Measurements were taken from the device. In MainActivity.onCreate:

val metrics = DisplayMetrics() windowManager.defaultDisplay.getMetrics(metrics) Log.e("lol", "${metrics.widthPixels}x${metrics.heightPixels}; ${metrics.xdpi}x${metrics.ydpi}")

Note: when calculating the physical measurements from the self-reported DPI measurements, the results were non-sensical so I didn't include the DPI or any physical measurements.

Pull Request checklist

codecov-io commented 5 years ago

Codecov Report

Merging #248 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #248   +/-   ##
=========================================
  Coverage     34.92%   34.92%           
  Complexity      372      372           
=========================================
  Files           122      122           
  Lines          3238     3238           
  Branches        505      505           
=========================================
  Hits           1131     1131           
  Misses         2008     2008           
  Partials         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e36a82...2abf38b. Read the comment docs.