mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show
Mozilla Public License 2.0
25 stars 12 forks source link

Closes #39: Wrap UserClearDataEvent in consumable. #256

Closed mcomella closed 5 years ago

mcomella commented 5 years ago

This is an accepted pattern on our team to send single-use events through an Observable.

Pull Request checklist

codecov-io commented 5 years ago

Codecov Report

Merging #256 into master will decrease coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #256      +/-   ##
==========================================
- Coverage     35.02%    35%   -0.03%     
  Complexity      371    371              
==========================================
  Files           123    123              
  Lines          3238   3240       +2     
  Branches        507    507              
==========================================
  Hits           1134   1134              
- Misses         2008   2010       +2     
  Partials         96     96
Impacted Files Coverage Δ Complexity Δ
...zilla/focus/settings/UserClearDataEventObserver.kt 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...main/java/org/mozilla/focus/utils/LiveDataEvent.kt 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...va/org/mozilla/focus/settings/ClearDataFragment.kt 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14fe5e8...1d8862d. Read the comment docs.