mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show
Mozilla Public License 2.0
25 stars 12 forks source link

No issue: ignore ExpiredTargetSdkVersion lint rule #291

Closed severinrudie closed 5 years ago

severinrudie commented 5 years ago

Pull Request checklist

mcomella commented 5 years ago

Android Lint failed with:

  The first 3 errors (out of 7) were:
  /home/travis/build/mozilla-mobile/firefox-echo-show/app/src/debug/AndroidManifest.xml:5: Error: Expecting an activity to have android.intent.category.LEANBACK_LAUNCHER intent filter. [MissingLeanbackLauncher]
  <manifest xmlns:android="http://schemas.android.com/apk/res/android"
   ~~~~~~~~
  /home/travis/build/mozilla-mobile/firefox-echo-show/app/src/main/AndroidManifest.xml:5: Error: Expecting an activity to have android.intent.category.LEANBACK_LAUNCHER intent filter. [MissingLeanbackLauncher]
  <manifest xmlns:android="http://schemas.android.com/apk/res/android"
   ~~~~~~~~
  /home/travis/build/mozilla-mobile/firefox-echo-show/app/src/debug/AndroidManifest.xml:5: Error: Hardware feature android.hardware.touchscreen not explicitly marked as optional  [ImpliedTouchscreenHardware]
  <manifest xmlns:android="http://schemas.android.com/apk/res/android"
   ~~~~~~~~
mcomella commented 5 years ago

Removing review request: Android lint still failed so I think it'd make more sense to review this when it's all fixed up.

@Baron-Severin FYI

dnarcese commented 5 years ago

Fixed in #302