Enable MediaSession permission on Echo Show

mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show

Mozilla Public License 2.0

25 stars 12 forks source link

Enable MediaSession permission on Echo Show #306

Closed liuche closed 4 years ago

liuche commented 5 years ago

Why/User Benefit/User Problem

Echo Show will get MediaSession features (voice control for play, pause, etc)

What / Requirements

Add MediaSession permission

Acceptance Criteria (how do I know when I’m done?)

Voice MediaSession permission is enabled
Build created & uploaded

liuche commented 5 years ago

@athomasmoz moving this here to the top to be prioritized!

mcomella commented 4 years ago

After this PR, I noticed no difference in the UX:

"Alexa pause" does not pause the video before or after the PR
Alexa does not provide "unknown command" feedback before or after the PR

nojunpark commented 4 years ago

@mcomella 'Alexa pause' pauses the video on echo 5 only, but it doesn't respond to 'Alexa play' or any other media command. On Echo 2, it pauses to process, but resumes after. Should I raise a separate bug? Considering that this issue is closed, I'll open another one.

mcomella commented 4 years ago

@npark-mozilla My understanding is that adding this permission wasn't intended to make Alexa voice commands work on these devices yet so I don't know if another issue is necessary until it's available in the platform.

@athomasmoz What do you think?

athomasmoz commented 4 years ago

Yep, that's correct. The voice commands aren't currently supported.