search

mozilla-mobile / firefox-echo-show

Firefox for Amazon's Echo Show
Mozilla Public License 2.0
25 stars 12 forks source link

Follow-up: selectively enable elevation on working devices #314

Closed mcomella closed 4 years ago

mcomella commented 4 years ago

Vision statement / What / Requirements

A side effect of #305 was that the toolbar casted a shadow on the initial homescreen on all devices:

device-2019-09-30-141245

I realized we can check each device in code to selectively enable it on the known working devices.

Impact

Acceptance criteria

mcomella commented 4 years ago

QA: please verify the same steps as https://github.com/mozilla-mobile/firefox-echo-show/issues/305#issuecomment-536768783. Also, as depicted in the screenshot of the bug for this PR, on the initial homescreen there should be a shadow on the ES5 but not on the ES 1st gen or 2nd gen.

nojunpark commented 4 years ago

@mcomella Seems the opposite - there is a shadow on Echo 2 (the big screen one), but only a line dividing the toolbar and the bottom panel on ES 5 (small screen device)

nojunpark commented 4 years ago

Echo 5: IMG_20191010_150609 Echo 2: IMG_20191010_150613

mcomella commented 4 years ago

@npark-mozilla This looks like I'd expect.

nojunpark commented 4 years ago

Thanks!