search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.21k stars 2.93k forks source link

Sync connect/disconnect push notification is not received #11085

Open SimonBasca opened 2 years ago

SimonBasca commented 2 years ago

Steps to reproduce

  1. Connect to FxA on iOS device A
  2. Connect to FxA on iOS device B

1. Expected behavior

# ## Actual behavior

# ## Device & build information

# ## Notes *## Same issue is reproducible for when disconnecting one of the devices. A push notification should be received on the other iOS device. Attachments:

┆Issue is synchronized with this Jira Task

dnarcese commented 2 years ago

@SimonBasca is a notification received on the iOS device if you sign in on a desktop device? Or is this issue specific to signing in on 2 iOS devices

SimonBasca commented 2 years ago

@dnarcese this is specific to signing in on 2 iOS devices, but we also had other cases when connect / disconnect push notification were functional and now are broken (e.g cases 3. and 4.).

  1. Connect on desktop after previously signing in to FxA on iOS -> no pus notification is received on iOS -- This was never functional
  2. Disconnect on desktop after previously signing in to FxA on both iOS and desktop -> no push notification is received on iOS -- This was never functional
  3. Connect on iOS after previously signing in to FxA on desktop -> no push notification is received on desktop -- This was functional
  4. Disconnect on iOS after previously signing in to FxA on iOS and desktop -> no push notification is received on desktop -- This was functional

For cases 3) and 4) I've logged https://github.com/mozilla-mobile/firefox-ios/issues/11130

data-sync-user commented 1 year ago

➤ Alina Moldovan commented:

Daniela Arcese this issue still reproduces using V1114 (30757)

The actual behavior is:

  1. Connect on desktop after previously signing in to FxA on iOS → No push notification is received on IOS
  2. Disconnect on desktop after previously signing in to FxA on both iOS and desktop → No push notification is received on IOS
  3. Connect on iOS after previously signing in to FxA on desktop → Push notification is received on desktop
  4. Disconnect on iOS after previously signing in to FxA on iOS and desktop → No push notification is received on desktop

Please note that even if https://github.com/mozilla-mobile/firefox-ios/issues/11130 ( https://github.com/mozilla-mobile/firefox-ios/issues/11130|smart-link ) was closed at some point it reproduces again.

DianaBarladeanu commented 1 year ago

The issue is still reproducing using V115 (31602). Another related issue is that after you disconnect from device B, the sync still remains on device A.

The actual behavior is:

  1. Connect on desktop after previously signing in to FxA on iOS → No push notification is received on IOS
  2. Disconnect on desktop after previously signing in to FxA on both iOS and desktop → No push notification is received on IOS and the sync remains.
github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

AdinaPetridean commented 4 months ago

Reproduced with the latest Firefox 128.0(v42711) on iPhone 14 Pro Max (iOS 16.2).