search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

[iPad] The magnifying icon is inactive on iPad #11502

Closed SimonBasca closed 1 year ago

SimonBasca commented 2 years ago

Steps to reproduce

  1. Open a new tab
  2. Observe the "magnifying" icon near the navigation buttons

    Expected behavior

image

┆Issue is synchronized with this Jira Task

dnarcese commented 2 years ago

I see this issue in v101 as well. This search button should not even appear on iPad, so the fix should be removing it. Will need UX to determine new spacing.

data-sync-user commented 2 years ago

➤ Tiffanie Shakespeare commented:

Michael Verdi can you help out on this one?

Verdi commented 2 years ago

If we want to do something quickly, I suggest either making it active or removing it and letting the address bar take up the extra space. This is also an issue on iOS in landscape BTW. Otherwise I'd like to address this as part of the new UI and IA work.

data-sync-user commented 1 year ago

➤ Tiffanie Shakespeare commented:

let’s do the quick option and revisit if we need in the later work. which option do you suggest Michael Verdi making it active or removing it?

when you make your final call, re-assign to daniela and she will pull it into a sprint to fix. thanks!

data-sync-user commented 1 year ago

➤ Michael Verdi commented:

Let’s remove it.

data-sync-user commented 1 year ago

➤ Winnie Teichmann commented:

Michael VerdiI don’t think we should be removing the search button. The button is changed to be the home button or reload depending on what is displayed (if we are on a website for example). I suggest we display the disabled reload icon instead as this will be probably displayed most of the time and be enabled once the user is a website.

data-sync-user commented 1 year ago

➤ Michael Verdi commented:

After talking this through with Winnie - the best approach here will be to make the search icon work as expected.

data-sync-user commented 1 year ago

➤ Simion Basca commented:

Verifying as fix on 109 (24441). The magnifying glass works as expected.