search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Handle visual effects theming #12106

Open data-sync-user opened 1 year ago

data-sync-user commented 1 year ago

For situations that use blur styles or other VFX instead of colors we need a way of theming them.

┆Issue is synchronized with this Jira Task

lmarceau commented 7 months ago

This task refers to UIColor.legacyTheme.tabTray.tabTitleBlur.

The solution to this for now is possibly to just add a method on the ThemeType, equivalent to public func keyboardAppearence(isPrivate: Bool) -> UIKeyboardAppearance { where we would get the blur style depending on the theme.

Once done, we can remove the UIColor.legacyTheme.tabTray.tabTitleBlur from our codebase since LegacyTabCell and TabCell can be using this new function.