search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.93k forks source link

The download remains paused and does not resume after enabling internet connection #12480

Closed SimonBasca closed 3 weeks ago

SimonBasca commented 1 year ago

Steps to reproduce

  1. Download a large file
  2. Turn off internet connection
  3. Enable internet connection

    Expected behavior

┆Issue is synchronized with this Jira Task

nishant2718 commented 1 year ago

Previously, downloads would resume if the app is made active again (https://github.com/mozilla-mobile/firefox-ios/pull/12241). With the scenes PR, this functionality was moved to sceneDidBecomeActive.

I recommend testing backgrounding & foregrounding the app as well here. If this doesn't work, I suspect we may have to move it to sceneWillEnterForeground 🤔

data-sync-user commented 1 year ago

➤ Simion Basca commented:

I see no issue when backgrounding the app and restoring while the download is in progress. The only problem is when disconnecting and reconnecting the internet connection.

data-sync-user commented 1 year ago

➤ Razvan Litianu commented:

Simion Basca Nishant Patel I looked at the code and it seems an error is thrown when disconnecting the internet and it’s explicitly removed from the queue. It looks like it’s the intended behavior unless we ignore this error. What do you think we should do in this case?

!Screenshot 2023-02-09 at 16.32.41 1.png|width=566,height=169!

data-sync-user commented 1 year ago

➤ Simion Basca commented:

Razvan Litianu in Safari when disconnecting the device from the internet while the download is in progress, the download is stopped but Safari has a way of resuming the download.

The expected behavior for me would be to resumed when turning on internet connection or pause the download and have a “Retry” button.

LeoniePhiline commented 1 year ago

I've come across this discrepancy recently when trying to download large congress talk recordings on a flaky congress WLAN.

I've had frustrating days with Firefox, as downloads would abort very frequently and had to be restarted from scratch (no range requests) and even by opening the source webpage and finding the download link again.

I had to switch to Safari, which provides all the described functionality (and more).

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

github-actions[bot] commented 3 weeks ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue linking to this one, with up-to-date information. Thank you!