Scanning the wrong QR code during sync setup gives a white screen

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.18k stars 2.92k forks source link

Scanning the wrong QR code during sync setup gives a white screen #12599

Open jrmuizel opened 1 year ago

jrmuizel commented 1 year ago

Steps to reproduce

Go to settings
Go to Sync and Save Data
Scan the QR code from https://accounts.firefox.com/pair?entrypoint=fx-view

Expected behavior

An error saying that the wrong QR code has been scanned.

Actual behavior

A white screen that nothing happens on

Device & build information

Device: iPhone 14 mini
Build version: 107.2

┆Issue is synchronized with this Jira Task

data-sync-user commented 11 months ago

➤ Norberto Andres Furlan commented:

[^RPReplay_Final1699386168(1).MP4]

vesta0 commented 7 months ago

We have addressed this confusion (leading to scanning the wrong code) in these new designs: https://www.figma.com/file/tSFjT8Sxid5GDXPL3BqK8l/Device-pairing-modal-update?type=design&node-id=4-18415&mode=design&t=dEcxA4jCUzrDKqRR-0

data-sync-user commented 6 months ago

➤ Chris Peterson commented:

FxA bug to redesign the “Connect Firefox on another device” page: https://bugzilla.mozilla.org/show_bug.cgi?id=1859700 ( https://bugzilla.mozilla.org/show_bug.cgi?id=1859700|smart-link )

data-sync-user commented 6 months ago

➤ Chris Peterson commented:

Ticket to redesign the pairing UX: https://mozilla-hub.atlassian.net/browse/FXA-8929 ( https://mozilla-hub.atlassian.net/browse/FXA-8929|smart-link )

data-sync-user commented 4 months ago

➤ Matt Lichtenstein commented:

Norberto Andres Furlan Vesta Zare I am not seeing any mobile UX for scanning the wrong QR code in those mockups - we currently still lead to a white page when an incorrect QR code is scanned.

data-sync-user commented 4 months ago

➤ Nishant Bhasin commented:

Note: We should be taking the user back to the sync screen if there is failure where they can start the sync again using the QR Code button

Flow:

Go to this scren sync and save data
Tap Ready to Scan
Scan incorrect QR Code
It should take you back to this page

Yes ideally there should be an error but for now this is the best interim solution on iOS side so the user can scan again based on any failure as we see white screen

Matt Lichtenstein Vesta Zare let me know if there is anything in pipeline from FxA Sync side for the white page if you aren’t satisfied with this fix

!Screenshot 2024-06-11 at 5.06.37 PM 2.jpeg|width=393,height=548,alt="Screenshot 2024-06-11 at 5.06.37 PM 2.jpeg"!

data-sync-user commented 3 months ago

➤ Adina Petridean commented:

Verified as fixed on v9000(43298) with iPhone 14 Pro Max (iOS 16.2).

If there's a failure, the user is redirected to the sync screen to restart the process using the QR Code button.

!wrong QR code.mp4|width=886,height=1920,alt="wrong QR code.mp4"!

data-sync-user commented 1 week ago

➤ Adina Petridean commented:

Verified as fixed on Firefox 132.0(46208) with iPhone 14 Pro Max (iOS 16.2).