[Share Sheet] Invalid "Lockwise" devices in device list for "Send to Device"

[FeBe95]

Steps to reproduce

• Open any website and open the Firefox share dialog.
• Tap "Send to Device" and wait for the list to load (~2-3 seconds).

Expected behavior

• The device list only contains devices names of actual Firefox installations.
• Devices named "Lockwise" shouldn't be in the list at all, as you can't send tabs to this app.
• The Lockwise app isn't even maintained anymore and is now integrated into Firefox itself.

Actual behavior

• The device list shows additional "devices" for current and stale Lockwise versions.
• I remember needing to re-login manually after some time not using the Lockwise app.
• Maybe each manual login created a new Lockwise instance in this list?

Device & build information

• Device: iPhone 13 Pro
• Build version: Firefox for iOS 107.3 (23248)
  1. Notes
• Over the years more and more instances of "Lockwise" appeared, to a total of 10 invalid devices until now.

Attachments:

┆Issue is synchronized with this Jira Task

[tarikeshaq]

In Firefox 109, we limit the send tab list to devices accessed in the last 21 days, so as long as you haven't accessed lockwise in 21 days it should get rid of itself once we release and you upgrade to 109 (around January!)

However, we should keep this ticket open to filter devices that don't support send tab.

The devices we get from FxA tell us if they support Send tab.

This can be done in https://github.com/mozilla-mobile/firefox-ios/blob/f68f9346c7387363880b9fd207f0fb6c919a1153/Client/Frontend/Extensions/DevicePickerViewController.swift#L132-L140

We can probably filter that based on the device's capabilities which is ignored in the above code.

There are other places remoteDevices is used, we should also make sure that if those end up being used for the purpose of send tab, we filter properly there too!

[FeBe95]

Just a short feedback: After updating to Firefox 109 the list is now cleaned up, with only my recent devices being shown. Although, as expected, Lockwise still re-appeared in the list right after I opened the app once again on my old iPhone.

[SimonBasca]

@FeBe95 should we mark this as completed or do you still believe there is an issue here?

[FeBe95]

@SimonBasca Well I don't have access to the Firefox iOS Beta v111, so I can't test the fix that was mentioned above myself right now. Though I have enough faith in you guys that I believe the PR will work as intended. So I am going to close this now. Thank you!