search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Night Mode Stuck #13736

Open nathanharig opened 1 year ago

nathanharig commented 1 year ago

Steps to reproduce

1) Launch any webpage from a freshly closed browser window, but have Automatic and Dark settings set on iOS

Expected behavior

2) Page renders regularly unless user specifically triggers night mode on the hamburger menu.

Actual behavior

3) Page renders in "night mode" no matter what. This default render happens when the app is closed, for new tabs, etc. It appears to be defaulting to night mode for webpage rendering no matter what AND inverting the page colors regardless of user prefs.

Device & build information

I did search for this a few times on here, only found 1 post where someone had a similar issue, but it was not solved.

I have a 12 Pro Max running iOS 16.3.1 running Firefox 111.1 (29556), and since well before that version (about a month now), I have had a persistant issue where "Night Mode" (that is, for webpages) is ALWAYS toggled on.

Dark mode (that is, my iPhone uses darker colors instead of white) is enabled on my phone, and settings do say to follow the Dark mode setting on my phone, but up until a month ago it would only do that for themeatic styling of the browser (tab bar, menus, etc) and not force night mode on every page. On pages that already use a dark styling, it is creating a horrible white inverted mess.

I can toggle night mode off, but as soon as the tab is closed, it will revert to rendering a page in night mode by default.

Is this just me? I have searched around forums and found I seem to be the only one with the issue. I've since switched to Chrome on my phone, but I love FF, it's my main driver on desktops. I'm not having this issue on my iPad Pro (also using iOS dark mode), which makes me think something with the phone settings is getting weird.

Thank you for your assistance.

Attachments:

┆Issue is synchronized with this Jira Task

martin-heinrich commented 1 year ago

Same problem here. Any new tab opens in dark mode regardless of the settings. It even does that when theme is set to manual and light.

iPhone 12 mini, iOS 16.4.1, Firefox 111.2 (29672)

nathanharig commented 1 year ago

I wound up uninstalling it on my iphone, rebooting the iphone, and reinstalling from the app store. That seems to have fixed it

On Sat, Apr 15, 2023 at 16:59 Martin Heinrich @.***> wrote:

Same problem here. Any new tab opens in dark mode regardless of the settings. It even does that when theme is set to manual and light.

iPhone 12 mini, iOS 16.4.1, Firefox 111.2 (29672)

— Reply to this email directly, view it on GitHub https://github.com/mozilla-mobile/firefox-ios/issues/13736#issuecomment-1509966802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKXTO55H2KV5HDOFFFDBITXBMD2RANCNFSM6AAAAAAWGVJ3IA . You are receiving this because you authored the thread.Message ID: @.***>

-- Nathan A Harig

martin-heinrich commented 1 year ago

That did the job. Thank you @nathanharig

markpfaff commented 1 year ago

Experiencing same issue. Going to try the uninstall and restart.