mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

Unable to create new tabs after tab delete #13833

Closed flg closed 3 weeks ago

flg commented 1 year ago

Steps to reproduce

With at least two tabs open, from an open tab, tap the tabs button to show all tabs. Swipe a tab out to delete it.

Expected behavior

The bottom bar should not disappear and creating new tabs should be possible. The keyboard should probably not be shown until a tab is selected and the address bar is shown where the text is entered.

Actual behavior

The keyboard is shown and the bottom bar (where the delete and the "+" button are shown) disappears. It's now impossible to create a new tab.

Device & build information

Notes

Attachments:

┆Issue is synchronized with this Jira Task

abodea commented 1 year ago

Thank you for adding this issue, can you re-attach the video, please? https://github.com/mozilla-mobile/firefox-ios/issues/13462 is this the issue you are encountering?

flg commented 1 year ago

13462 does not seem to describe this specific problem. Not sure I understood everything though.

flg commented 1 year ago

https://user-images.githubusercontent.com/325736/229453924-ddd78f66-cf62-4415-888e-cffbcdf6a338.mov

flg commented 1 year ago

Github does not seem happy with displaying the video but if I download it back from GH I can play it. Let me know if it works for you.

Thanks for looking into this issue.

flg commented 1 year ago

I noticed that the problem seems to occur only when, after the tab is removed by swiping, the focus falls on a unused tab (unused meaning that no web page was visited and the address bar is empty).

dnarcese commented 1 year ago

@abodea we landed fixes to attentive mode today, can you recheck this issue on tonight's nightly, please?

data-sync-user commented 6 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (41759), with iPhone 15 (17.4).

data-sync-user commented 6 months ago

➤ Catalin Suciu commented:

Closing as it’s been verified as fixed on v127.0b1 also.