Homepage settings state doesn't get updated and remains `Firefox Home`

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.2k stars 2.92k forks source link

Homepage settings state doesn't get updated and remains `Firefox Home` #14157

Open nbhasin2 opened 1 year ago

nbhasin2 commented 1 year ago

Steps to reproduce

Open Firefox -> Settings -> Home Page -> Last Tab
Go back to Settings page

Expected behavior

The Homepage settings description should state correct state Last Tab or Homepage

Actual behavior

The Homepage settings description will stay Firefox Home

Device & build information

Device: iPhone 14 pro or any other iOS device
Build version: v112.2 (30158)
First seen version: ?
Notes

Attachments:

┆Issue is synchronized with this Jira Task

esraaeiid commented 1 year ago

Hi @nbhasin2

I believe the inconvenience comes from the fact that there are two different selections—one for the home page and the other for the opening screen—and it updates on the home page rather than the opening screen when I choose a custom URL.

https://user-images.githubusercontent.com/38051115/234911217-cdf2ed49-3f01-46cf-9029-ff4cbf14ae65.MP4

dnarcese commented 1 year ago

This is confusing because there are multiple selections within that menu. It is pulling the selection from 'Current Homepage' not 'Opening Screen'. Looking for UX help on what we should display.