mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.93k forks source link

Add sign in with apple capability to Firefox iOS App ID #14339

Open dlactin opened 1 year ago

dlactin commented 1 year ago

User Problem

We are configuring Firefox Accounts to enable Sign in with Apple capabilities, this is currently being tested in stage. We see the generic Apple logo on the auth consent screen. Unfortunately, it looks like there is no way to add a logo to our Firefox Accounts App IDs without having an app published to the store with that ID.

Ideas for Solution

If we add the Sign in with Apple capability to the Firefox iOS app ID which is published to the app store, we can configure the Firefox Accounts App IDs to use this as their primary App ID which will add the published logo to the Firefox Accounts consent screen.

cc nbhasin2 dnarcese

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

Heitor Neiva My assumption is this is something that requires all prod profiles to be re-generated as we will be adding the following to the capabilities of the respective Firefox / Fennec ID

!image-20230530-193920.png|width=1838,height=278!

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

We are aiming to add this for our v114.1 dot release which will go out (June, 13)

Will likely just add it and if I am stuck I will tag Heitor Neiva for help

data-sync-user commented 1 year ago

➤ Andrei Bodea commented:

Hello, Nishant Bhasinis this gonna be ready soon? Will there be enough time to QA it? I’m not really sure how big the feature is but everything related to accounts is always complicated.

data-sync-user commented 1 year ago

➤ Jessilyn Davis commented:

Nishant Bhasin - when will this go live on June 13? Our team is eager to see how this will work when live. Can you check out these questions for what we should expect once it’s live?

https://mozilla-hub.atlassian.net/browse/FXA-4844?focusedCommentId=692243 ( https://mozilla-hub.atlassian.net/browse/FXA-4844?focusedCommentId=692243 )

Re this comment ( https://mozilla-hub.atlassian.net/browse/FXIOS-6382?focusedCommentId=689361 ):

{quote}My assumption is this is something that requires all prod profiles to be re-generated as we will be adding the following to the capabilities of the respective Firefox / Fennec ID{quote}

Is this something that impacts Firefox users in what they see or do? Or just internal Release Engineering management? (FWIW, we’re working to enable Google SSO as well for FxA ( https://mozilla-hub.atlassian.net/browse/FXA-7304 )) cc Heitor Neiva Vijay Budhram

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

Hi, Jessilyn Davis

Apologies for the delay. We were dealing with an incident on Firefox iOS side today where we had to submit a new v114.1 to Apple hence we are running bit late on this work.

Heitor Neiva let me know when you are ready and we can generate new profiles. Afaik even if I generate the profiles I can only do it for dev which isn’t that helpful if we want to upload it to Bitrise

data-sync-user commented 1 year ago

➤ Jessilyn Davis commented:

No worries! I hope everything is okay Nishant Bhasin ! Thank you for helping us move this forward as you’re able.

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

Added capability to our Firefox iOS Production provisioning profile Although you won’t see this take effect until our next dot release.

When we have a release candidate ready for 14.2, I will ping Jessilyn Davis and Vijay Budhram to try it out.

!image-20230608-212150.png|width=1278,height=996!

data-sync-user commented 1 year ago

➤ Jessilyn Davis commented:

Thank you Nishant Bhasin ! Is the dot release still on track for launch on June 13?

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

Jessilyn Davis Hi, dot release went out for v114.2 (31625)

We are currently in phased rollout so the best way to get the app would be manually downloading it from AppStore

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

Even though the dot release went out it seems like we need to also update entitlement which we missed.

I have made a PR here https://github.com/mozilla-mobile/firefox-ios/pull/14961 ( https://github.com/mozilla-mobile/firefox-ios/pull/14961|smart-link )

Heitor Neiva let me know if you feel there is anything else also required?

cc Daniela Arcese Tagged you to check if we can maybe add it as dot release as currently I have marked it as v116

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

Another update: Aiming to ship this change in v114.3 (next dot release)

Updated the PR as well, just waiting for this to get merged. cc Jessilyn Davis Daniela Arcese

data-sync-user commented 1 year ago

➤ Jessilyn Davis commented:

Thank you Nishant Bhasin ! Daniela Arcese - please confirm that this can go in the v114.3 dot release next week. This needs to be fixed before our go/no-go meeting on 23 June for the Pocket to Firefox Account migration (OKR project many months in the making). We need Pocket users who log in with Apple SSO to see the Firefox branding rather than the current “Firefox Accounts Auth Stage” branding (or else our launch date is at risk): https://mozilla-hub.atlassian.net/browse/FXA-4844 ( https://mozilla-hub.atlassian.net/browse/FXA-4844|smart-link )

data-sync-user commented 1 year ago

➤ Daniela Arcese commented:

Yes this can go in 114.3

data-sync-user commented 1 year ago

➤ Andrei Bodea commented:

Hello, as discussed on Slack with Nishant Bhasin, this will be verified first by Jessilyn Davis team, and once it’s working we will perform our checks.

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

This has been pushed to v114.3, please let me know if encounter an issue

data-sync-user commented 1 year ago

➤ Jessilyn Davis commented:

Looks great! Thank you Nishant Bhasin ! FYI Dustin Lactin

!Screenshot 2023-06-27 at 10.41.44 AM.png|width=640,height=530!

data-sync-user commented 1 year ago

➤ Nishant Bhasin commented:

Dustin Lactin I have moved to Needs QA, let me know if there is any QA required here

data-sync-user commented 1 year ago

➤ Jessilyn Davis commented:

I think we can call this QA verified - Dustin Lactin and QA verified as part of this ticket: https://mozilla-hub.atlassian.net/browse/FXA-4844 ( https://mozilla-hub.atlassian.net/browse/FXA-4844|smart-link )

data-sync-user commented 6 months ago

➤ Alina Moldovan commented:

Marking this ticket as closed based on the previous comment