search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.21k stars 2.93k forks source link

The privacy policy text link adds large spaces and a scroll effect is displayed in the onboarding #14427

Open abodea opened 1 year ago

abodea commented 1 year ago

Steps to reproduce

  1. Set the language in any other but English (e.g. Spanish, Italian, German).
  2. Install and launch FF.
  3. Observe the onboarding card with the privacy policy text link.

    Expected behavior

    The onboarding should not be scrollable and big empty spaces should be eliminated.

    Actual behavior

    The privacy policy text link adds large spaces and a scroll effect is displayed in the onboarding.

    Device & build information

image0 (5) image2 image1 (2)

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 year ago

➤ Daniela Arcese commented:

Andrei Bodea can you check if this is still reproducible please?

abodea commented 1 year ago

Hello, @dnarcese I re-checked on v9000 (34474) latest Nightly and nothing changed. You can see that because of the elements are too big some of the users might not notice you need to scroll to see everything, might not be very user-friendly for onboarding.

https://github.com/mozilla-mobile/firefox-ios/assets/42831109/95c34eb1-94ba-4e0e-9359-c8d203ed0f8e

https://github.com/mozilla-mobile/firefox-ios/assets/42831109/3144bca8-d0b2-44f1-9f8c-aabf4d428f1e

data-sync-user commented 6 months ago

➤ Adina Petridean commented:

Verified as fixed on v9000(40626), with iPhone 14 Pro Max (16.2). The onboarding pages no longer allow scrolling.

!onboarding.jpeg|width=430,height=932,alt="onboarding.jpeg"!

data-sync-user commented 5 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v127 (41813), with iPhone 15 (17.4).

!AF2B3B32-09D1-478A-829C-9CD4EA8551C6.jpg|width=944,height=2048,alt="AF2B3B32-09D1-478A-829C-9CD4EA8551C6.jpg"!